Differential D49589

tcp: remove support for TCPPCAP
ClosedPublic
Actions

Authored by tuexen on Mon, Mar 31, 2:19 PM.

Tags

None

Referenced Files

	F115397569: D49589.diff
	Wed, Apr 23, 9:30 AM

	Unknown Object (File)
	Thu, Apr 17, 6:31 AM

	Unknown Object (File)
	Thu, Apr 17, 2:47 AM

	Unknown Object (File)
	Mon, Apr 14, 12:17 PM

	Unknown Object (File)
	Sat, Apr 12, 12:54 AM

	Unknown Object (File)
	Sat, Apr 12, 12:54 AM

	Unknown Object (File)
	Sat, Apr 12, 12:54 AM

	Unknown Object (File)
	Sat, Apr 12, 12:54 AM

View All 14 Files

Subscribers

Details

Reviewers

jtl
rrs
rscheff
cc
peter.lei_ieee.org
lstewart
glebius

Group Reviewers

Commits

rG6e76489098c6: tcp: remove support for TCPPCAP

Summary

This feature could be used to store the last sent and received TCP packets for a TCP endpoint. There was no utility to get these packets from the kernel or core. This functionality is now provided by TCP Black Box Logging, which also stores additional events. There are tools to get these traces from a live system or a core.
Therefore remove TCPPCAP to avoid maintaining it, although it is not used anymore.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tuexen created this revision.Mon, Mar 31, 2:19 PM

Herald added a reviewer: transport. · View Herald TranscriptMon, Mar 31, 2:19 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Mon, Mar 31, 2:19 PM

rrs accepted this revision.Mon, Mar 31, 3:06 PM

This revision is now accepted and ready to land.Mon, Mar 31, 3:06 PM

rscheff accepted this revision.Mon, Mar 31, 3:19 PM

glebius accepted this revision.Mon, Mar 31, 3:44 PM

peter.lei_ieee.org accepted this revision.Mon, Mar 31, 4:09 PM

This was committed in 6e76489098c6.

tuexen added a commit: rG6e76489098c6: tcp: remove support for TCPPCAP.Tue, Apr 1, 10:57 AM

Revision Contents
Changeset List

Path

Size

ObsoleteFiles.inc

3 lines

sys/

conf/

4 lines

2 lines

1 line

netinet/

4 lines

7 lines

12 lines

24 lines

33 lines

4 lines

tools/

build/

test-includes/

usr.sbin/

tcpsso/

2 lines

Diff 152903

ObsoleteFiles.inc

Loading...

sys/conf/NOTES

Loading...

sys/conf/files

Loading...

sys/conf/options

Loading...

sys/netinet/tcp.h

Loading...

sys/netinet/tcp_input.c

Loading...

sys/netinet/tcp_output.c

Loading...

sys/netinet/tcp_pcap.h

Loading...

sys/netinet/tcp_pcap.c

Loading...

sys/netinet/tcp_subr.c

Loading...

sys/netinet/tcp_usrreq.c

Loading...

sys/netinet/tcp_var.h

Loading...

tools/build/test-includes/badfiles.inc

Loading...

usr.sbin/tcpsso/tcpsso.c

Loading...