tcp: initialize the LRO hash table correctly
ClosedPublic
Actions

Authored by tuexen on Aug 20 2024, 1:18 PM.

Details

Reviewers

rrs
rscheff
cc
lstewart
peter.lei_ieee.org

Group Reviewers

transport

Commits

rG5420e4f56389: tcp: initialize the LRO hash table with correct size
rGe0bcb3aa4f07: tcp: initialize the LRO hash table with correct size
rGaa6c490bf80f: tcp: initialize the LRO hash table with correct size

Summary

There will at most lro_entries entries in the LRO hash table. So no need to take lro_mbufs into account, which only results in the LRO hash table being too large and therefore wasting memory.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Aug 20 2024, 1:18 PM

Herald added a reviewer: transport. · View Herald TranscriptAug 20 2024, 1:18 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Aug 20 2024, 1:18 PM

rrs accepted this revision.Aug 20 2024, 2:40 PM

This revision is now accepted and ready to land.Aug 20 2024, 2:40 PM

Closed by commit rGaa6c490bf80f: tcp: initialize the LRO hash table with correct size (authored by tuexen). · Explain WhyAug 20 2024, 3:35 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGaa6c490bf80f: tcp: initialize the LRO hash table with correct size.

tuexen added a commit: rGe0bcb3aa4f07: tcp: initialize the LRO hash table with correct size.Aug 30 2024, 6:30 AM

tuexen added a commit: rG5420e4f56389: tcp: initialize the LRO hash table with correct size.Aug 30 2024, 6:45 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_lro.c

8 lines

Diff 142268

View Options

tcp: initialize the LRO hash table correctlyClosedPublicActions