Page MenuHomeFreeBSD

TCP RACK: remove code that cannot be reached
ClosedPublic

Authored by tuexen on Jan 3 2025, 1:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 11:14 PM
Unknown Object (File)
Wed, Oct 8, 12:31 AM
Unknown Object (File)
Sun, Sep 28, 1:59 AM
Unknown Object (File)
Sat, Sep 20, 8:27 PM
Unknown Object (File)
Wed, Sep 17, 2:42 PM
Unknown Object (File)
Sep 14 2025, 9:15 PM
Unknown Object (File)
Sep 11 2025, 3:53 AM
Unknown Object (File)
Sep 3 2025, 5:49 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen requested review of this revision.Jan 3 2025, 1:53 PM

Are you sure this condition cannot be reached?

I would suspect you can have available data and the pace_tmr_rxt can be up ...

In D48301#1101717, @rrs wrote:

Are you sure this condition cannot be reached?

I would suspect you can have available data and the pace_tmr_rxt can be up ...

The code I am removing would only call return, if rsm == NULL and tmr_up == PACE_TMR_RXT. This condition can not be true, since the condition before if (rsm == NULL) reads:

	if (((rsm == NULL) || (tp->t_state < TCPS_ESTABLISHED)) &&
	    (tmr_up == PACE_TMR_RXT)) {
		/* Should be an RXT */
		return;
	}

which means we would return from that condition and never reach the code I am removing.

This revision is now accepted and ready to land.Jan 4 2025, 1:09 PM
This revision was automatically updated to reflect the committed changes.