tcp: don't define and use BBLog function when TCP_BLACKBOX is not defined

[tuexen]

Summary

No functional change intended.

[rscheff]

Wouldn't it be possible to #define tcp_lro_log in a #else of the first block, such that this scattering of #ifdef's throughout the file could be avoided?

#ifdef TCP_BLACKBOX
static void
tcp_lro_log(struct tcpcb *tp, const struct lro_ctrl *lc,
    const struct lro_entry *le, const struct mbuf *m,
    int frm, int32_t tcp_data_len, uint32_t th_seq,
    uint32_t th_ack, uint16_t th_win)
{
:
}
#else
#define tcp_lro_log(tp, lc, le, m, frm, tcp_data_len, th_seq, th_ack, th_win)
#endif

[tuexen]

In D47401#1081163, @rscheff wrote:

Wouldn't it be possible to #define tcp_lro_log in a #else of the first block, such that this scattering of #ifdef's throughout the file could be avoided?

#ifdef TCP_BLACKBOX
static void
tcp_lro_log(struct tcpcb *tp, const struct lro_ctrl *lc,
    const struct lro_entry *le, const struct mbuf *m,
    int frm, int32_t tcp_data_len, uint32_t th_seq,
    uint32_t th_ack, uint16_t th_win)
{
:
}
#else
#define tcp_lro_log(tp, lc, le, m, frm, tcp_data_len, th_seq, th_ack, th_win)
#endif

That is possible. However, I prefer to see that the code is not executed compared to look up the definition of tcp_lro_log() a couple of times. This this is a subjective preference...

[rrs]

I agree with Michael here, macros badly hide things.. which is their intention :)