No functional change intended.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Wouldn't it be possible to #define tcp_lro_log in a #else of the first block, such that this scattering of #ifdef's throughout the file could be avoided?
#ifdef TCP_BLACKBOX
static void
tcp_lro_log(struct tcpcb *tp, const struct lro_ctrl *lc,
const struct lro_entry *le, const struct mbuf *m,
int frm, int32_t tcp_data_len, uint32_t th_seq,
uint32_t th_ack, uint16_t th_win)
{
:
}
#else
#define tcp_lro_log(tp, lc, le, m, frm, tcp_data_len, th_seq, th_ack, th_win)
#endifComment Actions
That is possible. However, I prefer to see that the code is not executed compared to look up the definition of tcp_lro_log() a couple of times. This this is a subjective preference...