udp: Prefer memcpy() over bcopy
ClosedPublic
Actions

Authored by zlei on Nov 23 2024, 4:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 2, 5:38 PM

	Unknown Object (File)
	Mon, Mar 23, 11:14 AM

	Unknown Object (File)
	Sat, Mar 21, 12:16 AM

	Unknown Object (File)
	Fri, Mar 20, 5:51 PM

	Unknown Object (File)
	Fri, Mar 13, 1:10 PM

	Unknown Object (File)
	Fri, Mar 13, 12:29 PM

	Unknown Object (File)
	Fri, Mar 13, 12:28 AM

	Unknown Object (File)
	Thu, Mar 12, 2:39 PM

View All Files

Subscribers

imp

melifaro

Details

Reviewers

glebius
cc
rrs
cy

Group Reviewers

transport
network

Commits

rG0b80bf9edb19: udp: Prefer memcpy() over bcopy()
rG949190c5afbc: udp: Prefer memcpy() over bcopy()

Summary

The variable b[] is on stack, thus can not overlap with ipov which
points to heap area, so prefer memcpy() over memmove(), aka bcopy().

No functional change intended.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Nov 23 2024, 4:05 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptNov 23 2024, 4:05 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

zlei requested review of this revision.Nov 23 2024, 4:05 PM

cc accepted this revision as: cc.Nov 25 2024, 2:43 PM

rrs accepted this revision.Nov 25 2024, 4:19 PM

This revision is now accepted and ready to land.Nov 25 2024, 4:19 PM

cy accepted this revision.Nov 25 2024, 6:28 PM

Closed by commit rG949190c5afbc: udp: Prefer memcpy() over bcopy() (authored by zlei). · Explain WhyNov 28 2024, 10:05 AM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG949190c5afbc: udp: Prefer memcpy() over bcopy().

zlei added a commit: rG0b80bf9edb19: udp: Prefer memcpy() over bcopy().Dec 6 2024, 1:53 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

udp_usrreq.c

4 lines

Diff 147107

View Options

udp: Prefer memcpy() over bcopyClosedPublicActions