Page MenuHomeFreeBSD

tcp: small cleanup
ClosedPublic

Authored by tuexen on Sep 30 2024, 6:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 6, 7:25 AM
Unknown Object (File)
Tue, Sep 30, 5:03 AM
Unknown Object (File)
Wed, Sep 24, 7:28 AM
Unknown Object (File)
Aug 14 2025, 11:52 PM
Unknown Object (File)
Aug 13 2025, 6:00 PM
Unknown Object (File)
Aug 3 2025, 2:42 PM
Unknown Object (File)
Aug 3 2025, 7:38 AM
Unknown Object (File)
Jul 30 2025, 3:11 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

glebius added inline comments.
sys/netinet/tcp_syncache.c
1588

No objection on this change, but I personally preferred the original style.

tuexen added inline comments.
sys/netinet/tcp_syncache.c
1588

Me too. But then the line is too long. The alternative would be:

if ((sc = uma_zalloc(V_tcp_syncache.zone,
    M_NOWAIT | M_ZERO)) == NULL) {

I think the way proposed is simpler to read.

This revision is now accepted and ready to land.Oct 1 2024, 7:51 AM

Looks good to me. Thanks for removing the goto label skip_alloc that improves reading.

This revision was automatically updated to reflect the committed changes.