No functional change intended.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/netinet/tcp_syncache.c | ||
|---|---|---|
| 1588 | No objection on this change, but I personally preferred the original style. | |
| sys/netinet/tcp_syncache.c | ||
|---|---|---|
| 1588 | Me too. But then the line is too long. The alternative would be: if ((sc = uma_zalloc(V_tcp_syncache.zone,
M_NOWAIT | M_ZERO)) == NULL) {I think the way proposed is simpler to read. | |
Comment Actions
Looks good to me. Thanks for removing the goto label skip_alloc that improves reading.