tcp rack: fix memory corruption
ClosedPublic
Actions

Authored by tuexen on Apr 5 2024, 8:22 PM.

Details

Reviewers

rrs
rscheff
lstewart

Group Reviewers

transport

Commits

rGc6770e8c99ab: tcp rack: fix memory corruption
rGd902c8f55b8d: tcp rack: fix memory corruption

Summary

When in rack_output() jumping to the label out, don't write errno into the log buffer, since the pointer is not initialized.

Reported by: Coverity Scan
CID: 1523773

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Apr 5 2024, 8:22 PM

Herald added a reviewer: transport. · View Herald TranscriptApr 5 2024, 8:22 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Apr 5 2024, 8:22 PM

rscheff accepted this revision.Apr 5 2024, 9:20 PM

This revision is now accepted and ready to land.Apr 5 2024, 9:20 PM

Closed by commit rGd902c8f55b8d: tcp rack: fix memory corruption (authored by tuexen). · Explain WhyApr 6 2024, 8:01 AM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGd902c8f55b8d: tcp rack: fix memory corruption.

tuexen added a commit: rGc6770e8c99ab: tcp rack: fix memory corruption.Wed, Apr 17, 1:59 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

rack.c

4 lines

Diff 136590

View Options

sys/netinet/tcp_stacks/rack.c

tcp rack: fix memory corruptionClosedPublicActions