Page MenuHomeFreeBSD

Refactor tcp_get_srtt()

Authored by jtl on May 27 2023, 3:06 PM.
Referenced Files
Unknown Object (File)
Tue, Sep 12, 2:51 PM
Unknown Object (File)
Tue, Sep 5, 11:05 PM
Unknown Object (File)
Fri, Sep 1, 7:27 PM
Unknown Object (File)
Aug 16 2023, 12:43 AM
Unknown Object (File)
Aug 14 2023, 3:36 PM
Unknown Object (File)
Aug 14 2023, 2:49 AM
Unknown Object (File)
Aug 8 2023, 12:55 AM
Unknown Object (File)
Aug 8 2023, 12:48 AM



After rGf5abdb03119a, it looks like there is an opportunity to refactor tcp_get_srtt() into its two component operations: unit conversion and shifting.

This should not cause any functional change.

Note for the future: I question whether it is a good idea for the long-term to manage the complexity of maintaining alternate unit storage in the TCB. If there is not already a plan for unifying the unit used for these values, I think we should consider making one.

Diff Detail

rG FreeBSD src repository
Lint Not Applicable
Tests Not Applicable

Event Timeline

jtl requested review of this revision.May 27 2023, 3:06 PM

There is the plan to move the base stack away from ticks and use usecs everywhere. But we wanted not to do this before stable/14 is branched.

This revision is now accepted and ready to land.May 27 2023, 7:01 PM
This revision was automatically updated to reflect the committed changes.