Page MenuHomeFreeBSD

Refactor tcp_get_srtt()
ClosedPublic

Authored by jtl on May 27 2023, 3:06 PM.
Tags
None
Referenced Files
F84384759: D40304.diff
Thu, May 23, 3:29 AM
Unknown Object (File)
Apr 9 2024, 7:35 AM
Unknown Object (File)
Jan 30 2024, 1:24 AM
Unknown Object (File)
Dec 22 2023, 11:57 PM
Unknown Object (File)
Dec 12 2023, 1:41 AM
Unknown Object (File)
Dec 9 2023, 10:52 AM
Unknown Object (File)
Sep 12 2023, 2:51 PM
Unknown Object (File)
Sep 5 2023, 11:05 PM

Details

Summary

After rGf5abdb03119a, it looks like there is an opportunity to refactor tcp_get_srtt() into its two component operations: unit conversion and shifting.

This should not cause any functional change.

Note for the future: I question whether it is a good idea for the long-term to manage the complexity of maintaining alternate unit storage in the TCB. If there is not already a plan for unifying the unit used for these values, I think we should consider making one.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jtl requested review of this revision.May 27 2023, 3:06 PM

There is the plan to move the base stack away from ticks and use usecs everywhere. But we wanted not to do this before stable/14 is branched.

This revision is now accepted and ready to land.May 27 2023, 7:01 PM
This revision was automatically updated to reflect the committed changes.