User Details
- User Since
- Sep 24 2014, 4:00 PM (533 w, 2 d)
Jun 8 2021
Apr 28 2021
The same feature was added with r357606 revision: We can close this review.
Sep 5 2019
This change is not needed anymore as it has been fixed with r324945
Nov 12 2018
Nov 11 2018
Nov 9 2018
Nov 7 2018
Nov 5 2018
Address @np comment
Address @np comment
Nov 1 2018
Jun 15 2018
Jun 13 2018
Oct 24 2017
Oct 2 2017
Oct 1 2017
Sep 7 2017
Jan 17 2017
Nov 24 2016
Nov 7 2016
Nov 3 2016
Oct 26 2016
Oct 25 2016
Fixed and MFC'ed with rS307551: Fix a double-free when an inp transitions to INP_TIMEWAIT state.
Oct 19 2016
gnn accepted this revision.
Oct 18 2016
Oct 17 2016
Still need someone from -transport to approve this review though. :)
Oct 13 2016
Review from Slawa:
- log(LOG_ERR) and workaround a difficult to debug case when INVARIANT is not defined
- Add a tcp_twstart KASSERT
Oct 12 2016
Thanks for your time on this review, will push this change as soon as D8211: Fix a double-free when an inp transitions to INP_TIMEWAIT state after having been dropped. is complete.
Oct 10 2016
Fix a comment typo
Currently only @slw_zxy.spb.ru and @girgen have reproduced this issue thus are able to validate this change, I have not been able to reproduce it but our TCP QA is all good with this change.
Oct 9 2016
Sep 30 2016
Sep 29 2016
Jul 27 2016
Jul 18 2016
Jul 14 2016
Jul 6 2016
Jul 4 2016
Looks good to me, let me launch our TCP QA on it.
Jul 1 2016
I agree with this change spirit:
Apr 25 2016
Tested on top of -CURRENT r298539 and all good. Performance are the same with and without this patch (this is expected). Green light from me.
Apr 19 2016
I starting testing this callout_async_drain() usage and so far so good. Let me upgrade our lab to a more recent revision of -CURRENT and I will report my findings here (should be by the end of this week).
Apr 15 2016
Apr 12 2016
Nice to see callout_async_drain() in action, TCP timer code being (much) cleaner. Will review this change, and run our usual TCP torture tests on it.
Dec 23 2015
I approve this server-side TFO implementation, it is a solid first implementation we can build on.
Nov 3 2015
Oct 16 2015
Oct 9 2015
Good example of using callout_drain_async().
I approve this change for MPSAFE callouts. As I lack of specific tests (and knowledge) for non-MPSAFE callouts, I would like another reviewer to look at it (@rrs?).
I have used and tested callout_async_drain() for TCP timer callouts and all good, everything works as expected. I would suggest you to create a review that depends on this one, to show how to use callout_async_drain() as a real example. What I did for my testing:
Oct 8 2015
I am indeed for adding callout_drain_async() as this is exactly what we are doing with TCP timer callouts in HEAD, stable/10 and releng/10.2, but it is currently done using callout_stop()/callout_reset() in a non simple way instead of using directly callout_drain_async().
Sep 15 2015
Let me try to try callout_drain_async() in top of our last TCP changes. I will put the results here.
I do approve the addition of this function, it would have made my life much easier for these two tasks:
Aug 30 2015
Change put back with rS287304: Put r284245 back in place: If at first this fix was seen as a temporary, as it turns out this change is not a workaround for a callout_stop() bug, but the right to use callout_stop()/callout_reset() in mpsafe mode. Should be the last change in the task to remove TCP timers race conditions started with D2079: Fix TCP timers use-after-free old race conditions.
Change reverted in rS287305: Revert r286880: If at first this change made sense, it turns out, thanks for your time sharing the subtlety of callout_stop() in mpsafe mode.
Aug 27 2015
Hi guys, after emails exchanges with @helasky and @kib I believe that if this change makes sense and improves some callout usages (i.e. in TCP timers) it is not worth it overall. In details:
Updated with hselaski inputs