Chelsio/netmap: propagate disabled IFCAP checksum flags to kernel
Needs ReviewPublic
Actions

Authored by jch on Nov 11 2018, 9:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Aug 14, 7:08 PM

	Unknown Object (File)
	Thu, Aug 13, 4:48 PM

	Unknown Object (File)
	Wed, Aug 12, 3:06 PM

	Unknown Object (File)
	Wed, Aug 12, 8:36 AM

	Unknown Object (File)
	Tue, Aug 11, 4:18 AM

	Unknown Object (File)
	Sun, Aug 9, 12:57 AM

	Unknown Object (File)
	Sat, Aug 8, 4:28 PM

	Unknown Object (File)
	Sat, Aug 8, 3:12 AM

View All 91 Files

Subscribers

bwicht_verisign.com

Details

Reviewers

Summary

This is the companion change of D17910:

Once unsupported / unneeded hardware flags are disabled from netmap,
it is needed to propagate them to kernel via ifp->if_hwassist. Otherwise,
packet might be sent without checksum as the kernel was expecting
the NIC to do it.

Submitted by: Marc de la Gueronniere <mdelagueronniere@verisign.com>
MFC after: 1 week
Sponsored by: Verisign, Inc.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20756
Build 20157: arc lint + arc unit

Event Timeline

jch created this revision.Nov 11 2018, 9:51 PM

Herald added a subscriber: ae. · View Herald TranscriptNov 11 2018, 9:51 PM

Harbormaster completed remote builds in B20756: Diff 50291.Nov 11 2018, 9:51 PM

jch added a reviewer: np.Nov 11 2018, 9:51 PM

jch added a parent revision: D17910: netmap: automatically disable some capabilities over vlan interface.Nov 11 2018, 9:54 PM

bwicht_verisign.com added a subscriber: bwicht_verisign.com.Sep 5 2019, 1:53 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

t4_netmap.c

19 lines

Diff 50291

View Options

Chelsio/netmap: propagate disabled IFCAP checksum flags to kernelNeeds ReviewPublicActions