netmap: automatically disable some capabilities over vlan interface
AbandonedPublic
Actions

Authored by jsmith_verisign.com on Nov 8 2018, 5:11 PM.

Details

Reviewers

jch
vmaffione

Summary

Disable problematic capabilities (vlan stripping, checksum offloading, tso, lro) when using using netmap on vlan interfaces
Restore inhibited capabilities when leaving netmap mode

Submitted by: Marc de la Gueronniere <mdelagueronniere@verisign.com>
MFC after: 1 week
Sponsored by: Verisign, Inc.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20704
Build 20117: arc lint + arc unit

Event Timeline

jsmith_verisign.com created this revision.Nov 8 2018, 5:11 PM

Harbormaster completed remote builds in B20704: Diff 50174.Nov 8 2018, 5:11 PM

jsmith_verisign.com retitled this revision from netmap: automatically disable some capabilities over vlan interface - Disable problematic capabilities (vlan stripping, checksum offloading, tso, lro) when using using netmap on vlan interfaces - Restore inhibited capabilities when leaving... to netmap: automatically disable some capabilities over vlan interface.Nov 8 2018, 5:12 PM

jsmith_verisign.com edited the summary of this revision. (Show Details)

jsmith_verisign.com added a subscriber: jch.Nov 8 2018, 6:24 PM

jch mentioned this in D17951: Chelsio/netmap: propagate disabled IFCAP checksum flags to kernel.Nov 11 2018, 9:51 PM

jch added a child revision: D17951: Chelsio/netmap: propagate disabled IFCAP checksum flags to kernel.Nov 11 2018, 9:54 PM

jch added a reviewer: vmaffione.Nov 11 2018, 10:12 PM

I'm sorry, but as a design decision for netmap we never automatically change interface features/offloading automatically and restore them.
We require the application or the system administrator to do so explicitely.
In any case this must be discussed with the upstream project https://github.com/luigirizzo/netmap

bwicht_verisign.com added a subscriber: bwicht_verisign.com.Sep 5 2019, 1:52 PM

vmaffione resigned from this revision.Aug 19 2020, 5:55 PM

In D17910#383510, @vmaffione wrote:

I'm sorry, but as a design decision for netmap we never automatically change interface features/offloading automatically and restore them.
We require the application or the system administrator to do so explicitely.
In any case this must be discussed with the upstream project https://github.com/luigirizzo/netmap

Closing this review and will open a pull request on upstream project https://github.com/luigirizzo/netmap directly, and will discuss this change there. Thanks!

jch added a reviewer: jch.Jun 8 2021, 2:11 PM

Closed this diff to take the matter upstream.