Page MenuHomeFreeBSD

netmap: automatically disable some capabilities over vlan interface
AbandonedPublic

Authored by jsmith_verisign.com on Nov 8 2018, 5:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 7:57 AM
Unknown Object (File)
Sat, Oct 4, 6:38 PM
Unknown Object (File)
Fri, Oct 3, 2:18 AM
Unknown Object (File)
Fri, Oct 3, 12:19 AM
Unknown Object (File)
Thu, Sep 18, 8:16 PM
Unknown Object (File)
Thu, Sep 18, 6:18 PM
Unknown Object (File)
Wed, Sep 17, 4:07 PM
Unknown Object (File)
Fri, Sep 12, 1:19 AM

Details

Reviewers
jch
vmaffione
Summary
  • Disable problematic capabilities (vlan stripping, checksum offloading, tso, lro) when using using netmap on vlan interfaces
  • Restore inhibited capabilities when leaving netmap mode

Submitted by: Marc de la Gueronniere <mdelagueronniere@verisign.com>
MFC after: 1 week
Sponsored by: Verisign, Inc.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20704
Build 20117: arc lint + arc unit

Event Timeline

jsmith_verisign.com retitled this revision from netmap: automatically disable some capabilities over vlan interface - Disable problematic capabilities (vlan stripping, checksum offloading, tso, lro) when using using netmap on vlan interfaces - Restore inhibited capabilities when leaving... to netmap: automatically disable some capabilities over vlan interface.Nov 8 2018, 5:12 PM
jsmith_verisign.com edited the summary of this revision. (Show Details)

I'm sorry, but as a design decision for netmap we never automatically change interface features/offloading automatically and restore them.
We require the application or the system administrator to do so explicitely.
In any case this must be discussed with the upstream project https://github.com/luigirizzo/netmap

I'm sorry, but as a design decision for netmap we never automatically change interface features/offloading automatically and restore them.
We require the application or the system administrator to do so explicitely.
In any case this must be discussed with the upstream project https://github.com/luigirizzo/netmap

Closing this review and will open a pull request on upstream project https://github.com/luigirizzo/netmap directly, and will discuss this change there. Thanks!

Closed this diff to take the matter upstream.