Page MenuHomeFreeBSD
Differential D17896

netmap: netmap_transmit should honor bpf packet tap hook.
ClosedPublic
Actions

Authored by jsmith_verisign.com on Nov 7 2018, 7:23 PM.
Tags
None
Referenced Files
F156433314: D17896.id51643.diff
Wed, May 13, 4:36 PM
Unknown Object (File)
Mon, May 11, 7:10 AM
Unknown Object (File)
Mon, May 11, 7:10 AM
Unknown Object (File)
Tue, May 5, 8:33 PM
Unknown Object (File)
Tue, May 5, 10:55 AM
Unknown Object (File)
Sun, May 3, 4:11 PM
Unknown Object (File)
Mon, Apr 27, 1:26 PM
Unknown Object (File)
Sat, Apr 25, 1:49 AM
View All Files
Subscribers
bwicht_verisign.com
• franco_opnsense.org
imp
jch

Details

Reviewers
vmaffione
gnn
Commits
rS342034: MFC r341624
rS342031: MFC r341624
rS341624: netmap: netmap_transmit should honor bpf packet tap hook
Summary

This allows tcpdump to capture outbound kernel packets while
in netmap mode

Submitted by: Marc de la Gueronniere <mdelagueronniere@verisign.com>
MFC after: 1 week
Sponsored by: Verisign, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jsmith_verisign.com created this revision.Nov 7 2018, 7:23 PM
Harbormaster completed remote builds in B20690: Diff 50133.Nov 7 2018, 7:23 PM
jsmith_verisign.com added a subscriber: jch.Nov 8 2018, 6:24 PM
jch added a reviewer: vmaffione.Nov 11 2018, 10:10 PM
vmaffione added inline comments.Nov 12 2018, 9:55 AM
sys/dev/netmap/netmap.c
3659 ↗(On Diff #50133)

Please make this compile-time conditional

#ifdef __FreeBSD__
jsmith_verisign.com updated this revision to Diff 50347.Nov 12 2018, 10:38 PM

Address @vmaffione comment

Harbormaster completed remote builds in B20774: Diff 50347.Nov 12 2018, 10:38 PM
jsmith_verisign.com marked an inline comment as done.Nov 12 2018, 10:40 PM

Added FreeBSD conditional

vmaffione accepted this revision.Nov 13 2018, 9:13 AM
This revision is now accepted and ready to land.Nov 13 2018, 9:13 AM
vmaffione added a reviewer: gnn.Dec 6 2018, 9:33 AM
Closed by commit rS341624: netmap: netmap_transmit should honor bpf packet tap hook (authored by vmaffione). · Explain WhyDec 6 2018, 9:45 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptDec 6 2018, 9:45 AM
• franco_opnsense.org added a subscriber: • franco_opnsense.org.Dec 11 2018, 2:15 PM
bwicht_verisign.com added a subscriber: bwicht_verisign.com.Sep 5 2019, 1:52 PM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
netmap/
5 lines

Diff 51643

View Options

head/sys/dev/netmap/netmap.c

Loading...