netmap: netmap_transmit should honor bpf packet tap hook.
ClosedPublic
Actions

Authored by jsmith_verisign.com on Nov 7 2018, 7:23 PM.

Details

Reviewers

vmaffione
gnn

Commits

rS342034: MFC r341624
rS342031: MFC r341624
rS341624: netmap: netmap_transmit should honor bpf packet tap hook

Summary

This allows tcpdump to capture outbound kernel packets while
in netmap mode

Submitted by: Marc de la Gueronniere <mdelagueronniere@verisign.com>
MFC after: 1 week
Sponsored by: Verisign, Inc.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20774
Build 20173: arc lint + arc unit

Event Timeline

jsmith_verisign.com created this revision.Nov 7 2018, 7:23 PM

Harbormaster completed remote builds in B20690: Diff 50133.Nov 7 2018, 7:23 PM

jsmith_verisign.com added a subscriber: jch.Nov 8 2018, 6:24 PM

jch added a reviewer: vmaffione.Nov 11 2018, 10:10 PM

vmaffione added inline comments.Nov 12 2018, 9:55 AM

sys/dev/netmap/netmap.c
3659	Please make this compile-time conditional #ifdef __FreeBSD__

Address @vmaffione comment

Harbormaster completed remote builds in B20774: Diff 50347.Nov 12 2018, 10:38 PM

Added FreeBSD conditional

vmaffione accepted this revision.Nov 13 2018, 9:13 AM

This revision is now accepted and ready to land.Nov 13 2018, 9:13 AM

vmaffione added a reviewer: gnn.Dec 6 2018, 9:33 AM

Closed by commit rS341624: netmap: netmap_transmit should honor bpf packet tap hook (authored by vmaffione). · Explain WhyDec 6 2018, 9:45 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptDec 6 2018, 9:45 AM

franco_opnsense.org added a subscriber: franco_opnsense.org.Dec 11 2018, 2:15 PM

bwicht_verisign.com added a subscriber: bwicht_verisign.com.Sep 5 2019, 1:52 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

netmap/

netmap.c

3 lines

Diff 50347

View Options

netmap: netmap_transmit should honor bpf packet tap hook.ClosedPublicActions