Page MenuHomeFreeBSD

Remove an extraneous call to soisconnected() in syncache_socket(), introduced with r261242.
ClosedPublic

Authored by jch on Sep 29 2016, 11:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 20, 9:47 AM
Unknown Object (File)
Fri, Sep 19, 3:22 PM
Unknown Object (File)
Fri, Sep 19, 12:24 PM
Unknown Object (File)
Mon, Sep 15, 7:36 PM
Unknown Object (File)
Mon, Sep 15, 2:18 AM
Unknown Object (File)
Sat, Sep 13, 1:38 PM
Unknown Object (File)
Sep 5 2025, 11:01 PM
Unknown Object (File)
Aug 20 2025, 1:08 AM
Subscribers

Details

Summary

Remove an extraneous call to soisconnected() in syncache_socket(), introduced with rS261242
The useful and expected soisconnected() call is done in tcp_do_segment().

Has been found as part of PR:212920 investigation.

Improve slightly (~2%) the maximum number of TCP accept per second.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jch retitled this revision from to Remove an extraneous call to soisconnected() in syncache_socket(), introduced with r261242..
jch updated this object.
jch edited the test plan for this revision. (Show Details)
jch added reviewers: gnn, hiren, adrian.
jch edited edge metadata.

As far as I can tell this is good. I have a box serving large volume of internet facing traffic with a data accept filter.

gnn edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 3 2016, 9:59 AM
hiren edited edge metadata.

As Kevin mentioned, this looks good on prod traffic at llnw.

This revision was automatically updated to reflect the committed changes.