Jun 29 2022
Jan 27 2022
Jun 11 2021
Mar 17 2021
Jan 24 2021
Jul 17 2020
Jul 16 2020
Sorry for the mess, my latest actions on this differential were unintentional, some problems with old Firefox.
CCing Roman Kurakin (ce(4)) and Serge Vakulenko (cp(4)), see later.
In case anybody is wondering, the source of the commit is here: https://freshbsd.org/commit/netbsd/src/hRr2tvIj1vj7QI2C
Jul 7 2020
Jun 25 2020
Good catch on the tidbits, here's an revised patch.
This looks ok to me modulo the nits I pointed out.
Jun 24 2020
Made the corrections.
Jun 23 2020
Jan 20 2020
Jan 16 2020
Dec 31 2019
Sep 30 2019
May 9 2019
Apr 25 2019
Lawrence reviewed this during IETF104, Michael volunteered to follup up with the full commit process.
Apr 24 2019
Mar 28 2019
Feb 15 2019
Feb 5 2019
- prepare to land
Over the last two or three weeks, we have run a large number of performance regression tests including this patch, in particular again workloads with frequent app-stalls (no additional data to send for about an RTO interval). That type of workload very often causes burst to be transmitted, including self-inflicted packet drops.
Jan 31 2019
Looks good. I think Richard can update more that we recently tested this patch.
Jan 24 2019
Looking at D8225, that all seems to be code while in loss recovery. This patch is to restore a sane minimum cwnd once exiting loss recovery - so I don't see how these would be directly related.
I remember we tried to analyze and improve this and found some unintended consequences between @hiren and @lstewart https://reviews.freebsd.org/D8225 so it got backed out. @lstewart do you remember the details for backing it out?
Jan 18 2019
- fixing trailing whitespaces
- remove siftr patch
- fixing trailing whitespaces
Here is the output of the now functional siftr, without and with the patch;
Jan 16 2019
Jan 15 2019
I have been testing this patch against a stable/11 build. Over a 1Gb/s link with emulated 40ms RTT and (10^-4) loss rate, I use iperf from a FreeBSD node to send traffic to a 4.15.0-39-generic Ubuntu16.04 client.
Jan 3 2019
Attached is a tcptrace of a real-world observed issue, where the lack of RFC6582 results in cwnd shrinking down to 1 MSS, followed by delayed ACK timeout and congestion avoidance growth of cwnd (1 MSS per RTT).