Page MenuHomeFreeBSD

if_spppsubr: Define a few LCP options, Recognize (but still reject) multilink PPP config options
AbandonedPublic

Authored by eugen_grosbein.net on Jul 16 2020, 2:12 AM.

Details

Reviewers
nc
Summary

if_spppsubr: Define a few more LCP options. Recognize, sanity-check and report (but still reject for the moment) multilink PPP configuration options received.

Submitted by: Neel Chauhan <neel AT neelc DOT org>
Obtained from: NetBSD

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

nc requested review of this revision.Jul 16 2020, 2:12 AM

In case anybody is wondering, the source of the commit is here: https://freshbsd.org/commit/netbsd/src/hRr2tvIj1vj7QI2C

CCing Roman Kurakin (ce(4)) and Serge Vakulenko (cp(4)), see later.

16.07.2020 9:23, neel_neelc.org (Neel Chauhan) wrote:

neel_neelc.org abandoned this revision.

REPOSITORY

rS FreeBSD src repository

CHANGES SINCE LAST ACTION

https://reviews.freebsd.org/D25681/new/

REVISION DETAIL

https://reviews.freebsd.org/D25681

I wonder if we really have use cases for sppp(4)/ng_sppp(4) these days.

This code was created in 199x to support some synchronous Cronyx adapters and their drivers:

ce(4) for PCI G.703/E1 card,
cp(4) for PCI V.35/RS-232/RS-530/RS-449/X.21/G.703/E1/E3/T3/STS-1 cards,
and cx(4)/ctau(4) for some ISA cards but these do not exist in FreeBSD 13 anymore,
removed by emaste@ recently.

Both ce(4) and cp(4) are i386-only drivers at present.

I could not find any other consumers of sppp code in base system and
I doubt there are outside base, but I may be wrong.

I'd like to see some comments from rik and vak, though.

eugen_grosbein.net reclaimed this revision.
eugen_grosbein.net added a reviewer: nc.

Sorry for the mess, my latest actions on this differential were unintentional, some problems with old Firefox.

ce(4) for PCI G.703/E1 card,
cp(4) for PCI V.35/RS-232/RS-530/RS-449/X.21/G.703/E1/E3/T3/STS-1 cards,
and cx(4)/ctau(4) for some ISA cards but these do not exist in FreeBSD 13 anymore,
removed by emaste@ recently.

Both ce(4) and cp(4) are i386-only drivers at present.

Such synchronous lines are still in use (here):

  • G.703 is common in phone systems.
  • X.21 for leased lines (with old contracts),
  • E1/E3 for SDH (carrier grade) leases lines.
  • RS-232 is the ordinary serial port, the other RS- are industry specific serials (mainly other voltages)

But you are right: Do we really need a specialized PPP hardware support these days?
Do we really want to run a recent kernel on this antique hardware? It would be a sacrilege.

Normal PPP over serial lines (currently available) does work using ppp(4)

In D25681#568379, @lutz_donnerhacke.de wrote:

ce(4) for PCI G.703/E1 card,
cp(4) for PCI V.35/RS-232/RS-530/RS-449/X.21/G.703/E1/E3/T3/STS-1 cards,
and cx(4)/ctau(4) for some ISA cards but these do not exist in FreeBSD 13 anymore,
removed by emaste@ recently.

Both ce(4) and cp(4) are i386-only drivers at present.

Such synchronous lines are still in use (here):

  • G.703 is common in phone systems.
  • X.21 for leased lines (with old contracts),
  • E1/E3 for SDH (carrier grade) leases lines.
  • RS-232 is the ordinary serial port, the other RS- are industry specific serials (mainly other voltages)

But you are right: Do we really need a specialized PPP hardware support these days?
Do we really want to run a recent kernel on this antique hardware? It would be a sacrilege.

Normal PPP over serial lines (currently available) does work using ppp(4)

Makes 100% sense.

I almost forgot this when writing this patch: NetBSD is purposely designed for your old Compaq or Packard Bell with ancient hardware, whereas FreeBSD is for more modern hardware.

And the oldest computer I have access to here in the Seattle area is from 2013, that not my primary. My 2000s and 90s hardware is back at my dad's place in New York.