Page MenuHomeFreeBSD

jonlooney_gmail.com (Jonathan Looney)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 15 2015, 2:43 PM (460 w, 2 d)

Recent Activity

Jul 26 2016

jonlooney_gmail.com removed a member for network: jonlooney_gmail.com.
Jul 26 2016, 2:41 PM
jonlooney_gmail.com removed a member for transport: jonlooney_gmail.com.
Jul 26 2016, 2:41 PM

Oct 29 2015

jonlooney_gmail.com added reviewers for D3864: Add a safety net to reclaim mbufs when one of the mbuf zones become exhausted: rrs, bz, network.
Oct 29 2015, 12:19 AM · network
jonlooney_gmail.com added a comment to D3864: Add a safety net to reclaim mbufs when one of the mbuf zones become exhausted.

If anyone has time to review this, I'd appreciate it.

Oct 29 2015, 12:18 AM · network

Oct 15 2015

jonlooney_gmail.com updated the diff for D3864: Add a safety net to reclaim mbufs when one of the mbuf zones become exhausted.

Added a lock around the callout calls.

Oct 15 2015, 7:13 PM · network
jonlooney_gmail.com added a comment to D3864: Add a safety net to reclaim mbufs when one of the mbuf zones become exhausted.
In D3864#81077, @rrs wrote:

Should not the callout have some sort of lock?

You declare it MP-SAFE but I see no lock as described in the man pages
for callout_reset and friends..

Oct 15 2015, 6:12 PM · network

Oct 14 2015

jonlooney_gmail.com added inline comments to D3100: TCP packet capture for debugging.
Oct 14 2015, 11:37 PM · network

Oct 10 2015

jonlooney_gmail.com added inline comments to D3100: TCP packet capture for debugging.
Oct 10 2015, 2:25 PM · network
jonlooney_gmail.com added inline comments to D3863: Use m_cat() to reassembly IPv6 packets.
Oct 10 2015, 1:46 PM · network
jonlooney_gmail.com retitled D3864: Add a safety net to reclaim mbufs when one of the mbuf zones become exhausted from to Add a safety net to reclaim mbufs when one of the mbuf zones become exhausted.
Oct 10 2015, 2:19 AM · network
jonlooney_gmail.com retitled D3863: Use m_cat() to reassembly IPv6 packets from to Use m_cat() to reassembly IPv6 packets.
Oct 10 2015, 2:01 AM · network

Jul 17 2015

jonlooney_gmail.com added a comment to D1499: Marry mbuf(9) and queue(3)..

It looks like this was committed in r278914. So, this review can probably be closed?

Jul 17 2015, 11:44 AM
jonlooney_gmail.com added a comment to D1887: Generic code for mbuf(9) queues..

Wasn't much of this already committed in r278977? If so, it seems like this review can be closed.

Jul 17 2015, 11:40 AM
jonlooney_gmail.com added a comment to D3100: TCP packet capture for debugging.
Jul 17 2015, 11:29 AM · network
jonlooney_gmail.com added inline comments to D3100: TCP packet capture for debugging.
Jul 17 2015, 12:27 AM · network
jonlooney_gmail.com updated the diff for D3100: TCP packet capture for debugging.

Addressed feedback:

  • Changed three-line comments to one-liners.
  • Updated the copyright notice on the new files.
  • Updated a few comments.
Jul 17 2015, 12:25 AM · network

Jul 16 2015

jonlooney_gmail.com added a comment to D3100: TCP packet capture for debugging.

Thanks for the feedback!

Jul 16 2015, 4:19 PM · network

Jul 15 2015

jonlooney_gmail.com added a member for network: jonlooney_gmail.com.
Jul 15 2015, 3:08 PM
jonlooney_gmail.com retitled D3100: TCP packet capture for debugging from to TCP packet capture for debugging.
Jul 15 2015, 3:04 PM · network