Page MenuHomeFreeBSD
Differential D43751

net80211: amrr_init: change order of commands
ClosedPublic
Actions

Authored by bz on Feb 5 2024, 2:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 16, 6:28 AM
Unknown Object (File)
Thu, Oct 16, 6:28 AM
Unknown Object (File)
Thu, Oct 16, 6:28 AM
Unknown Object (File)
Wed, Oct 15, 7:04 PM
Unknown Object (File)
Mon, Oct 6, 3:42 PM
Unknown Object (File)
Thu, Sep 18, 11:04 PM
Unknown Object (File)
Thu, Sep 18, 10:05 PM
Unknown Object (File)
Thu, Sep 18, 2:57 PM
View All 78 Files
Subscribers
glebius
imp
melifaro
wireless

Details

Reviewers
adrian
cc
Commits
rG8e64a7ec0b5d: net80211: amrr_init: change order of commands
rG634fd711b003: net80211: amrr_init: change order of commands
rGcd9fee3d2c37: net80211: amrr_init: change order of commands
Summary

First run the KASSERT before trying to do the free operation.
Better for reporting and debugging.
Add a guard setting the value to NULL afterwards. NULL pointers
are a lot easier to test for.

Note: we should really just change the amrr local ref to atomics.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
net80211/
3 lines

Diff 137057

View Options

sys/net80211/ieee80211_amrr.c

Loading...