Page MenuHomeFreeBSD
Differential D43751

net80211: amrr_init: change order of commands
ClosedPublic
Actions

Authored by bz on Feb 5 2024, 2:50 PM.
Tags
None
Referenced Files
F137954490: D43751.id137057.diff
Thu, Nov 27, 4:02 PM
Unknown Object (File)
Sun, Nov 23, 12:49 AM
Unknown Object (File)
Mon, Nov 17, 3:32 AM
Unknown Object (File)
Wed, Nov 12, 11:24 PM
Unknown Object (File)
Tue, Nov 4, 6:40 AM
Unknown Object (File)
Wed, Oct 29, 11:04 AM
Unknown Object (File)
Wed, Oct 29, 11:03 AM
Unknown Object (File)
Oct 25 2025, 7:52 PM
View All 88 Files
Subscribers
glebius
imp
melifaro
wireless

Details

Reviewers
adrian
cc
Commits
rG8e64a7ec0b5d: net80211: amrr_init: change order of commands
rG634fd711b003: net80211: amrr_init: change order of commands
rGcd9fee3d2c37: net80211: amrr_init: change order of commands
Summary

First run the KASSERT before trying to do the free operation.
Better for reporting and debugging.
Add a guard setting the value to NULL afterwards. NULL pointers
are a lot easier to test for.

Note: we should really just change the amrr local ref to atomics.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
net80211/
3 lines

Diff 137057

View Options

sys/net80211/ieee80211_amrr.c

Loading...