Page MenuHomeFreeBSD
Differential D46140

tcp: make sysctl variables ack_war_timewindow and ack_war_cnt vnet specific
ClosedPublic
Actions

Authored by tuexen on Jul 25 2024, 10:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 6, 4:23 PM
Unknown Object (File)
Fri, Sep 4, 3:33 PM
Unknown Object (File)
Wed, Sep 2, 2:56 PM
Unknown Object (File)
Mon, Aug 24, 5:15 AM
Unknown Object (File)
Sat, Aug 15, 9:43 PM
Unknown Object (File)
Tue, Aug 11, 7:17 PM
Unknown Object (File)
Tue, Aug 11, 7:17 PM
Unknown Object (File)
Tue, Aug 11, 7:17 PM
View All Files
Subscribers
imp
melifaro

Details

Reviewers
peter.lei_ieee.org
rrs
rscheff
glebius
cc
Group Reviewers
transport
Commits
rG4401d7b362b1: tcp: vnetify sysctl variables ack_war_timewindow and ack_war_cnt
rG4036380e0297: tcp: vnetify sysctl variables ack_war_timewindow and ack_war_cnt
Summary

As suggested by glebius@. While there, improve the documentation.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

tuexen created this revision.Jul 25 2024, 10:16 PM
Herald added a reviewer: transport. · View Herald TranscriptJul 25 2024, 10:16 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
tuexen requested review of this revision.Jul 25 2024, 10:16 PM
cc accepted this revision.Jul 26 2024, 3:29 PM

ship after update

sys/netinet/tcp_subr.c
145

(to ack_war_cnt) can just be (ack_war_cnt)

This revision is now accepted and ready to land.Jul 26 2024, 3:29 PM
peter.lei_ieee.org added a comment.Jul 26 2024, 4:31 PM

We need these applied to rack_bbr_common.c as well.

tuexen updated this revision to Diff 141447.Jul 26 2024, 4:53 PM

Add required changes to rack.c and rack_bbr_common.c.

This revision now requires review to proceed.Jul 26 2024, 4:53 PM
tuexen added a comment.Jul 26 2024, 4:53 PM
In D46140#1052086, @peter.lei_ieee.org wrote:

We need these applied to rack_bbr_common.c as well.

Thanks. Without those changes, the modules compile, but do not load. There was also a change in rack.c missing. Fixed now.

tuexen updated this revision to Diff 141449.Jul 26 2024, 4:56 PM

Address comment from cc@ and bump date in man page.

tuexen marked an inline comment as done.Jul 26 2024, 4:57 PM
tuexen added inline comments.
sys/netinet/tcp_subr.c
145

Fixed.

peter.lei_ieee.org accepted this revision.Jul 27 2024, 3:08 AM
This revision is now accepted and ready to land.Jul 27 2024, 3:08 AM
tuexen marked an inline comment as done.Jul 28 2024, 8:31 PM
tuexen closed this revision.Jul 28 2024, 8:48 PM

Committed in 4036380e0297.

tuexen added a commit: rG4036380e0297: tcp: vnetify sysctl variables ack_war_timewindow and ack_war_cnt.Aug 3 2024, 7:16 PM
tuexen added a commit: rG4401d7b362b1: tcp: vnetify sysctl variables ack_war_timewindow and ack_war_cnt.Aug 3 2024, 11:21 PM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
20 lines
sys/
netinet/
tcp_stacks/
2 lines
16 lines
24 lines
4 lines

Diff 141449

View Options

share/man/man4/tcp.4

Loading...
View Options

sys/netinet/tcp_stacks/rack.c

Loading...
View Options

sys/netinet/tcp_stacks/rack_bbr_common.c

Loading...
View Options

sys/netinet/tcp_subr.c

Loading...
View Options

sys/netinet/tcp_var.h

Loading...