I will let other reviewers do the final accept for transport.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Apr 6 2022
Apr 6 2022
Looks good to me. Thanks!
Apr 4 2022
Apr 4 2022
Mar 29 2022
Mar 29 2022
This for patching this up. My comments are inline.
Jan 28 2022
Jan 28 2022
Jan 27 2022
Jan 27 2022
Jan 26 2022
Jan 26 2022
chengc_netapp.com added inline comments to D33979: Only rewind erraneous RTO when previous values are truly valid.
chengc_netapp.com added inline comments to D33979: Only rewind erraneous RTO when previous values are truly valid.
Jan 21 2022
Jan 21 2022
Looks good to me. Thanks.
May 26 2021
May 26 2021
Looks good to me. Thanks for picking this up! :)
Feb 3 2021
Feb 3 2021
chengc_netapp.com added a comment to D26807: move cwnd and ssthresh updates into individual congestion control module.
The above discussion about tcp_maxseg() has been closed in the subjected email thread: https://lists.freebsd.org/pipermail/freebsd-transport/2020-November/000355.html
No further action needed.
Nov 19 2020
Nov 19 2020
chengc_netapp.com added a comment to D27275: Create new CC module to track cubic RFC 8312bis changes.
Is the rfc8312bis draft publicly available? Where can I find it?
Oct 15 2020
Oct 15 2020
chengc_netapp.com requested review of D26808: TCP Cubic: improve reaction to (and rollback from) RTO.
Oct 8 2020
Oct 8 2020
chengc_netapp.com requested changes to D26446: Stop sending tiny new data segments during SACK recovery.
Aug 27 2020
Aug 27 2020
Aug 18 2020
Aug 18 2020
Looks good. Thanks for picking this up.
chengc_netapp.com added inline comments to D26060: TCP Cubic: Recalculate cubic cwnd for every ack..
Verified this patch here:
https://github.com/ccui1000/freebsd-tcp/wiki/test-D26060
Aug 14 2020
Aug 14 2020
Aug 7 2020
Aug 7 2020
chengc_netapp.com accepted D25746: Address unintended jump of calculated cwnd when leaving slowstart.
Looks good. Thanks for picking this up.
Jul 30 2020
Jul 30 2020
chengc_netapp.com requested changes to D25746: Address unintended jump of calculated cwnd when leaving slowstart.
Tested with my results: https://github.com/ccui1000/freebsd-tcp/wiki/test-D25746
Jul 20 2020
Jul 20 2020
Jul 7 2020
Jul 7 2020
Jun 5 2020
Jun 5 2020
Good discovery. Thanks.
I think this has a higher priority than D25133.
May 12 2020
May 12 2020
Looks good. Thanks for picking this up.
Apr 21 2020
Apr 21 2020
Looks good. Thanks.
Feb 24 2020
Feb 24 2020
chengc_netapp.com added inline comments to D23353: ECN and CUBIC do not play well together in very congested networks.
Feb 19 2020
Feb 19 2020
Feb 14 2020
Feb 14 2020
Even better. Tested on my side. Looks good.
Jan 27 2020
Jan 27 2020
Looks the persistent timer may be still alive. Suggest revise this change.
Jan 21 2020
Jan 21 2020
Tested in both bsd11 and bsd12. Without this fix, I can find a 2nd retransmission triggered by the persistent timer, not the RTO timer. But this means the persistent timer is still alive. Suggest revise this change.
Did not find any problem in bsd11.
Did not find any problem in bsd11.
Did not find any problem.
Jan 17 2020
Jan 17 2020
I am testing this patch now. Will update from my side in one or two days.
Dec 30 2019
Dec 30 2019
Also, you can remove the CCF_DELACK definition from cc.h.
Dec 29 2019
Dec 29 2019
Nov 18 2019
Nov 18 2019
Oct 25 2019
Oct 25 2019
Aug 27 2019
Aug 27 2019
chengc_netapp.com added inline comments to D20549: fixing sysctl interface for DCTCP and types of dctcp variables.
Aug 20 2019
Aug 20 2019
chengc_netapp.com added inline comments to D20549: fixing sysctl interface for DCTCP and types of dctcp variables.
Aug 7 2019
Aug 7 2019
I believe rS87145 was submitted because of some unexpected DelayedACK
implementation, or it might be just the DelayedACK was expecting two full MSS
(instead of two segments that updated later) in FreeBSD 4.2/4.3 in 2001.
Jul 26 2019
Jul 26 2019
I prefer D18982 to be submitted. If D18982 is submitted, we don't need this patch as D18982 covers everything here.
Jun 11 2019
Jun 11 2019
chengc_netapp.com requested changes to D20549: fixing sysctl interface for DCTCP and types of dctcp variables.
Mar 25 2019
Mar 25 2019
Looks good to me. Will let @lstewart make the final decision.
Feb 5 2019
Feb 5 2019
Jan 31 2019
Jan 31 2019
chengc_netapp.com accepted D17614: RFC6582 - prevent cwnd to collapse down to 1 mss after exiting recovery.
Looks good. I think Richard can update more that we recently tested this patch.
Jan 29 2019
Jan 29 2019
Looks good. Thanks.
Jan 28 2019
Jan 28 2019
Jan 25 2019
Jan 25 2019
Jan 18 2019
Jan 18 2019
Looks good to me. If the summary can also be updated to represent the new context, that will be better. Thanks.
Jan 15 2019
Jan 15 2019
chengc_netapp.com added a comment to D17614: RFC6582 - prevent cwnd to collapse down to 1 mss after exiting recovery.
I have been testing this patch against a stable/11 build. Over a 1Gb/s link with emulated 40ms RTT and (10^-4) loss rate, I use iperf from a FreeBSD node to send traffic to a 4.15.0-39-generic Ubuntu16.04 client.
Jan 2 2019
Jan 2 2019
chengc_netapp.com added a comment to D17614: RFC6582 - prevent cwnd to collapse down to 1 mss after exiting recovery.
Thanks for the review request.
I will test this patch in Emulab.net before I give more feedback.