Page MenuHomeFreeBSD

tcp: remove check for condition that never happens
ClosedPublic

Authored by glebius on Jan 28 2025, 11:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 5, 3:58 AM
Unknown Object (File)
Aug 15 2025, 10:14 AM
Unknown Object (File)
Aug 12 2025, 4:00 AM
Unknown Object (File)
Jul 23 2025, 1:58 PM
Unknown Object (File)
Jul 21 2025, 5:05 AM
Unknown Object (File)
Jul 19 2025, 7:21 PM
Unknown Object (File)
Jul 19 2025, 3:58 PM
Unknown Object (File)
Jul 19 2025, 9:20 AM
Subscribers

Details

Summary

A tcpcb in TCPS_LISTEN has always socket in SO_ACCEPTCONN. One block
above there is an assertion that proves that this never happens. We
stopped ever clearing SO_ACCEPTCONN back in 779f106aa169.

This reverts commit 982c1675ff8864f51007e0be402ead88429222bb.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cc added a subscriber: cc.
cc added inline comments.
sys/netinet/tcp_input.c
1357

Right, this condition should not be valid any more.

This revision is now accepted and ready to land.Jan 31 2025, 3:10 PM