tcpsso: remove support for some IPPROTO_TCP-level socket option names
ClosedPublic
Actions

Authored by tuexen on Aug 26 2024, 8:45 AM.

Details

Reviewers

rrs
rscheff
cc
peter.lei_ieee.org
lstewart

Commits

rG6e25bccb989c: tcpsso: remove support for some IPPROTO_TCP-level socket option names

Summary

Remove support for IPPROTO_TCP-level socket option names, because these names will be removed from the source tree soon. The corresponding socket options are not implemented by the TCP stack at all.

This change was suggested by Peter Lei.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Aug 26 2024, 8:45 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 26 2024, 8:45 AM

tuexen requested review of this revision.Aug 26 2024, 8:45 AM

tuexen retitled this revision from tcpsso: remove some IPPROTO_TCP-level socket option names to tcpsso: remove support for some IPPROTO_TCP-level socket option names.

Are you planning to remove the corresponding code in kernel space in a separate patch?

In D46437#1058468, @cc wrote:

Are you planning to remove the corresponding code in kernel space in a separate patch?

Yes. I also need to patch the read_bbrlog port first. Once the consumers are gone, I'll remove the code from kernel space. In most cases, these are just #defines in tcp.h with no corresponding code.

cc accepted this revision.Aug 26 2024, 7:40 PM

This revision is now accepted and ready to land.Aug 26 2024, 7:40 PM

Closed by commit rG6e25bccb989c: tcpsso: remove support for some IPPROTO_TCP-level socket option names (authored by tuexen). · Explain WhyAug 30 2024, 7:37 AM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG6e25bccb989c: tcpsso: remove support for some IPPROTO_TCP-level socket option names.