Page MenuHomeFreeBSD

tcpsso: remove support for some IPPROTO_TCP-level socket option names
ClosedPublic

Authored by tuexen on Aug 26 2024, 8:45 AM.
Tags
None
Referenced Files
F102832739: D46437.id.diff
Sun, Nov 17, 6:27 PM
F102830253: D46437.id142424.diff
Sun, Nov 17, 5:47 PM
F102826007: D46437.id.diff
Sun, Nov 17, 4:48 PM
F102820863: D46437.diff
Sun, Nov 17, 3:08 PM
Unknown Object (File)
Sat, Nov 16, 12:36 PM
Unknown Object (File)
Sun, Nov 10, 1:30 AM
Unknown Object (File)
Fri, Nov 8, 12:12 AM
Unknown Object (File)
Tue, Nov 5, 2:52 PM
Subscribers

Details

Summary

Remove support for IPPROTO_TCP-level socket option names, because these names will be removed from the source tree soon. The corresponding socket options are not implemented by the TCP stack at all.

This change was suggested by Peter Lei.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen retitled this revision from tcpsso: remove some IPPROTO_TCP-level socket option names to tcpsso: remove support for some IPPROTO_TCP-level socket option names.

Are you planning to remove the corresponding code in kernel space in a separate patch?

In D46437#1058468, @cc wrote:

Are you planning to remove the corresponding code in kernel space in a separate patch?

Yes. I also need to patch the read_bbrlog port first. Once the consumers are gone, I'll remove the code from kernel space. In most cases, these are just #defines in tcp.h with no corresponding code.

This revision is now accepted and ready to land.Aug 26 2024, 7:40 PM