compat/linux: map TCP_USER_TIMEOUT sockopt into TCP_MAXUNACKTIME
ClosedPublic
Actions

Authored by sobomax on Mon, Mar 30, 5:26 PM.

Details

Reviewers

rrs
tuexen
glebius

Group Reviewers

Linux Emulation
transport

Commits

rG5d4a39d8ed77: compat/linux: map TCP_USER_TIMEOUT sockopt into TCP_MAXUNACKTIME

Summary

After reading both manual pages, our TCP_MAXUNACKTIME is fairly similar to the TCP_USER_TIMEOUT, the only considerable difference is ours is in seconds and linux's in milliseconds.

Round up linux's in setsockopt(2) and clamp ours to UINT_MAX.

Used nowadays by the tokio-runtime and sqlx-sqlite.

Test Plan

Run a linux app that uses this option.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sobomax created this revision.Mon, Mar 30, 5:26 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Mar 30, 5:26 PM

sobomax requested review of this revision.Mon, Mar 30, 5:26 PM

glebius added a reviewer: transport.Mon, Mar 30, 5:59 PM

glebius added a reviewer: rrs.Mon, Mar 30, 6:17 PM

tuexen accepted this revision.Mon, Mar 30, 6:26 PM

This revision is now accepted and ready to land.Mon, Mar 30, 6:26 PM

The Linux socket option also bound the time user data remains un-transmitted. I guess this is not handled by the FreeBSD one.

OT: I have an item to look at TCP_QUICKACK like Nagle suggested as per my DevSummit workplan

The code placement is ad-hoc. We already have a case for IPPROTO_TCP in the main switch and the new option handling should go there. This will require some extension of linux_to_bsd_tcp_sockopt() but the result would be cleaner code.

Implement suggestions from @glebius

This revision now requires review to proceed.Tue, Mar 31, 5:50 AM

In D56168#1284968, @glebius wrote:

The code placement is ad-hoc. We already have a case for IPPROTO_TCP in the main switch and the new option handling should go there. This will require some extension of linux_to_bsd_tcp_sockopt() but the result would be cleaner code.

Done.

This looks better, thanks! Let's give Randall a chance to review. He added this setsockopt() to FreeBSD.

This revision is now accepted and ready to land.Tue, Mar 31, 3:31 PM

tuexen accepted this revision.Tue, Mar 31, 8:53 PM

Closed by commit rG5d4a39d8ed77: compat/linux: map TCP_USER_TIMEOUT sockopt into TCP_MAXUNACKTIME (authored by sobomax). · Explain WhyWed, Apr 1, 9:50 PM

This revision was automatically updated to reflect the committed changes.

sobomax added a commit: rG5d4a39d8ed77: compat/linux: map TCP_USER_TIMEOUT sockopt into TCP_MAXUNACKTIME.