Paths

Table of Contentst

Differential D40104

bhyve: [snapshot] Rename 'structs' key with 'kern_structs'
ClosedPublic
Actions

Authored by gusev.vitaliy_gmail.com on May 15 2023, 1:48 PM.

Tags

Referenced Files

	F131867854: D40104.id121963.diff
	Sat, Oct 11, 8:05 PM

	F131867853: D40104.id.diff
	Sat, Oct 11, 8:05 PM

	F131867846: D40104.id123403.diff
	Sat, Oct 11, 8:05 PM

	Unknown Object (File)
	Sat, Oct 11, 11:09 AM

	Unknown Object (File)
	Thu, Oct 9, 7:20 AM

	Unknown Object (File)
	Tue, Oct 7, 1:08 AM

	Unknown Object (File)
	Sep 12 2025, 2:16 AM

	Unknown Object (File)
	Sep 10 2025, 7:29 AM

View All 86 Files

Subscribers

Details

Reviewers

corvink
rew

Group Reviewers

Commits

rG5a07451f796f: bhyve: rename 'structs' snapshot key with 'kern_structs'
rG50aef9f62c1b: bhyve: rename 'structs' snapshot key with 'kern_structs'

Summary

Using key 'structs' is ambiguous. This section contains data
related to the kernel. It should use a more informative naming.

Sponsored by: vStack

Related to multiple devices support.

Test Plan

Note,

.meta file contents is changed:
From "structs": [
to "kern_structs": [

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gusev.vitaliy_gmail.com created this revision.May 15 2023, 1:48 PM

Herald added a reviewer: bhyve. · View Herald TranscriptMay 15 2023, 1:48 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

gusev.vitaliy_gmail.com requested review of this revision.May 15 2023, 1:48 PM

gusev.vitaliy_gmail.com added a parent revision: D35590: bhyve: multiple devices support for suspend/checkpoint/resume.May 15 2023, 1:51 PM

gusev.vitaliy_gmail.com added a child revision: D40105: bhyve: [snapshot] Simplify restore kernel structs.

gusev.vitaliy_gmail.com edited the summary of this revision. (Show Details)May 15 2023, 1:55 PM

gusev.vitaliy_gmail.com mentioned this in D35590: bhyve: multiple devices support for suspend/checkpoint/resume.May 15 2023, 2:33 PM

rew accepted this revision as: rew.May 15 2023, 5:24 PM

This revision is now accepted and ready to land.May 15 2023, 5:24 PM

One general note: Please try to explain why a change is required in your commit message. "Related to xy" is not enough. It should explain why it is related to xy and what's the advantage of the patch.

gusev.vitaliy_gmail.com retitled this revision from bhyve: [snapshot] Rename 'struct' key with 'kern_struct' to bhyve: [snapshot] Rename 'struct's key with 'kern_structs'.Jun 14 2023, 12:01 AM

gusev.vitaliy_gmail.com edited the summary of this revision. (Show Details)

gusev.vitaliy_gmail.com retitled this revision from bhyve: [snapshot] Rename 'struct's key with 'kern_structs' to bhyve: [snapshot] Rename 'structs' key with 'kern_structs'.Jun 14 2023, 12:05 AM

Closed by commit rG50aef9f62c1b: bhyve: rename 'structs' snapshot key with 'kern_structs' (authored by gusev.vitaliy_gmail.com, committed by corvink). · Explain WhyJun 19 2023, 5:59 AM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rG50aef9f62c1b: bhyve: rename 'structs' snapshot key with 'kern_structs'.

corvink added a commit: rG5a07451f796f: bhyve: rename 'structs' snapshot key with 'kern_structs'.Aug 18 2023, 7:20 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

16 lines

Diff 123403

usr.sbin/bhyve/snapshot.c

Loading...