Page MenuHomeFreeBSD

vmm: Dynamically allocate a couple of per-CPU state save areas
ClosedPublic

Authored by markj on Apr 25 2023, 5:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 11, 11:15 PM
Unknown Object (File)
Mon, Jul 8, 4:32 AM
Unknown Object (File)
Tue, Jun 25, 6:16 AM
Unknown Object (File)
Jun 9 2024, 6:31 AM
Unknown Object (File)
Jun 3 2024, 9:58 AM
Unknown Object (File)
May 30 2024, 10:47 PM
Unknown Object (File)
May 27 2024, 1:19 PM
Unknown Object (File)
May 26 2024, 2:28 AM

Details

Summary

This avoids bloating the BSS when MAXCPU is large.

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Apr 25 2023, 5:22 PM

Would anyone be willing to test this on an AMD system?

Would anyone be willing to test this on an AMD system?

What kind of the tests? Just run VM? I can test it on Ryzen 3700x.

rew added a subscriber: rew.

Would anyone be willing to test this on an AMD system?

works for me

sys/amd64/vmm/amd/svm.c
257–266

should MAXCPU be pruned at some point?

This revision is now accepted and ready to land.Apr 25 2023, 7:24 PM
In D39805#906277, @rew wrote:

Would anyone be willing to test this on an AMD system?

works for me

Thanks.

Would anyone be willing to test this on an AMD system?

What kind of the tests? Just run VM? I can test it on Ryzen 3700x.

Yes, booting a guest ought to be enough. Not really necessary now that Rob tried it.

sys/amd64/vmm/amd/svm.c
257–266

Yeah, that's a follow-up step that I just didn't take since asid[] is much smaller.

somebody attempted a different kind of test: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271251 — Kernel panics when loading vmm module with VT-x disabled