Page MenuHomeFreeBSD

vmm/amd64: port illumos cpuid control
Needs ReviewPublic

Authored by rosenfeld_grumpf.hope-2000.org on Jul 26 2025, 11:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 9, 1:47 PM
Unknown Object (File)
Thu, Oct 9, 1:47 PM
Unknown Object (File)
Thu, Oct 9, 12:44 PM
Unknown Object (File)
Tue, Oct 7, 8:07 PM
Unknown Object (File)
Thu, Oct 2, 12:56 PM
Unknown Object (File)
Fri, Sep 26, 11:07 PM
Unknown Object (File)
Fri, Sep 26, 10:39 PM
Unknown Object (File)
Wed, Sep 24, 1:57 AM

Details

Reviewers
None
Group Reviewers
bhyve
Summary

This is a faithful port of two bhyve improvements coming from illumos:

This does not include the bhyve tests added with illumos#14485 since
FreeBSD lacks the bhyve test suite. This does also not contain any
libvmmapi/bhyve userspace code to make this feature actually useful.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65751
Build 62634: arc lint + arc unit

Event Timeline

corvink added inline comments.
sys/amd64/include/vmm.h
808
826
sys/amd64/vmm/vmm_cpuid.c
28

This shouldn't be required anymore.

572

This could be split into a separate commit to make it easier to review and merge earlier if you like to.

sys/amd64/vmm/vmm_dev_machdep.c
504–521

That's checked by vm_set_cpuid too. I would prefer checking this stuff once.

emaste added inline comments.
sys/amd64/vmm/vmm_cpuid.c
2
572

In general if this is a bug fix or otherwise an improvement that can stand alone I would indeed do it in a separate commit (that may be MFC'd to stable branches independent of or earlier than the full new functionality).