libvmmapi/amd64: add support for CPUID ioctls to libvmmapi
AcceptedPublic
Actions

Authored by rosenfeld_grumpf.hope-2000.org on Jul 26 2025, 11:21 AM.

Details

Reviewers

corvink
markj

Group Reviewers

bhyve

Summary

libvmmapi needs wrapper functions for the new vmm cpuid ioctls.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65753
Build 62636: arc lint + arc unit

Event Timeline

rosenfeld_grumpf.hope-2000.org created this revision.Jul 26 2025, 11:21 AM

Herald added a reviewer: bhyve. · View Herald TranscriptJul 26 2025, 11:21 AM

Herald added subscribers: rgrimes, imp. · View Herald Transcript

rosenfeld_grumpf.hope-2000.org requested review of this revision.Jul 26 2025, 11:21 AM

Harbormaster completed remote builds in B65753: Diff 159181.Jul 26 2025, 11:21 AM

rosenfeld_grumpf.hope-2000.org added a parent revision: D51553: vmm/amd64: VM_SET_CPUID ioctl should refuse zero-entry non-legacy cpuid cfg.Jul 26 2025, 11:22 AM

rosenfeld_grumpf.hope-2000.org added a child revision: D51555: bhyve/amd64: parse cpuid options.Jul 26 2025, 11:24 AM

corvink accepted this revision.Jul 28 2025, 9:39 AM

corvink added a subscriber: corvink.

corvink added inline comments.

lib/libvmmapi/amd64/vmmapi_machdep.c
359	Should cfg be cleared before calling the ioctl?

This revision is now accepted and ready to land.Jul 28 2025, 9:39 AM

rosenfeld_grumpf.hope-2000.org added inline comments.Mon, Oct 20, 8:02 AM

lib/libvmmapi/amd64/vmmapi_machdep.c
359	No, as it actually passes a parameter for the VM_GET_CPUID ioctl: cfg->vvcc_nent gives the size of the user-supplied buffer in units of cpuid entries.

markj accepted this revision as: markj.Tue, Oct 21, 3:20 PM

Revision Contents
Changeset List

Path

Size

lib/

libvmmapi/

amd64/

vmmapi_machdep.c

34 lines

vmmapi.h

4 lines

Diff 159181

View Options

lib/libvmmapi/amd64/vmmapi_machdep.c