libvmmapi needs wrapper functions for the new vmm cpuid ioctls.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 78612 Build 75495: arc lint + arc unit
Event Timeline
| lib/libvmmapi/amd64/vmmapi_machdep.c | ||
|---|---|---|
| 360 | Should cfg be cleared before calling the ioctl? | |
| lib/libvmmapi/amd64/vmmapi_machdep.c | ||
|---|---|---|
| 360 | No, as it actually passes a parameter for the VM_GET_CPUID ioctl: cfg->vvcc_nent gives the size of the user-supplied buffer in units of cpuid entries. | |
| usr.sbin/bhyvectl/amd64/bhyvectl_machdep.c | ||
|---|---|---|
| 5 ↗ | (On Diff #187994) | Looks like an unintentional change? |
| usr.sbin/bhyvectl/amd64/bhyvectl_machdep.c | ||
|---|---|---|
| 5 ↗ | (On Diff #187994) | Yes, looks like it. The more I think about it, I think the copyrights I added early on aren't really what they should be given this was work funded by the FreeBSD Foundation. If it makes sense I'll go and fix them all in all reviews? |
| usr.sbin/bhyvectl/amd64/bhyvectl_machdep.c | ||
|---|---|---|
| 5 ↗ | (On Diff #187994) | Yes please! |