amd64: Fix sys/pcpu.h usage in vmm_host.h and md_var.h
ClosedPublic
Actions

Authored by rosenfeld_grumpf.hope-2000.org on Jul 26 2025, 11:14 AM.

Details

Reviewers

corvink
markj

Group Reviewers

bhyve

Commits

rG202e3109a9d6: amd64: Fix sys/pcpu.h usage in vmm_host.h and md_var.h

Summary

Include sys/pcpu in vmm_host.h as its structs and functions are used
there, and add a forward declaration of struct pcpu to md_var.h as it
is used in some function prototypes.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rosenfeld_grumpf.hope-2000.org created this revision.Jul 26 2025, 11:14 AM

Herald added a reviewer: bhyve. · View Herald TranscriptJul 26 2025, 11:14 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

rosenfeld_grumpf.hope-2000.org requested review of this revision.Jul 26 2025, 11:14 AM

Harbormaster completed remote builds in B65749: Diff 159177.Jul 26 2025, 11:14 AM

rosenfeld_grumpf.hope-2000.org added a child revision: D51551: bhyve: want walk_config_nodes.Jul 26 2025, 11:16 AM

corvink accepted this revision.Jul 28 2025, 9:03 AM

This revision is now accepted and ready to land.Jul 28 2025, 9:03 AM

rosenfeld_grumpf.hope-2000.org retitled this revision from amd64: add missing include sys/pcpu.h to vmm_host.h and md_var.h to amd64: Add missing include sys/pcpu.h to vmm_host.h and md_var.h.Thu, Jan 15, 1:46 PM

Update commit message.

This revision now requires review to proceed.Thu, Jan 15, 1:47 PM

Harbormaster completed remote builds in B69913: Diff 169773.Thu, Jan 15, 1:47 PM

markj added a subscriber: markj.Thu, Jan 15, 1:48 PM

markj added inline comments.

sys/amd64/include/md_var.h
39	Why is pcpu.h needed here? Do we just need a forward declaration of `struct pcpu`? That can be added to the list below (starting with `struct __mcontext`).

rosenfeld_grumpf.hope-2000.org added inline comments.Thu, Jan 15, 6:51 PM

sys/amd64/include/md_var.h
39	I don't recall what the exact error was that I ran into, but whatever it was it is apparently gone since I've rebased my work on your recent header changes. I've reverted it locally and everything still seems to build just fine.

markj added inline comments.Thu, Jan 15, 8:21 PM

sys/amd64/include/md_var.h
39	I think the change to vmm_host.h is still reasonable.

rosenfeld_grumpf.hope-2000.org retitled this revision from amd64: Add missing include sys/pcpu.h to vmm_host.h and md_var.h to Fix sys/pcpu.h usage in vmm_host.h and md_var.h'.Fri, Jan 16, 2:32 PM

rosenfeld_grumpf.hope-2000.org edited the summary of this revision. (Show Details)

rosenfeld_grumpf.hope-2000.org retitled this revision from Fix sys/pcpu.h usage in vmm_host.h and md_var.h' to Fix sys/pcpu.h usage in vmm_host.h and md_var.h.

rosenfeld_grumpf.hope-2000.org retitled this revision from Fix sys/pcpu.h usage in vmm_host.h and md_var.h to amd64: Fix sys/pcpu.h usage in vmm_host.h and md_var.h.

Add only a forward declaration of struct pcpu to md_var.h as suggested by markj.

Harbormaster completed remote builds in B69922: Diff 169845.Fri, Jan 16, 2:34 PM

markj accepted this revision as: markj.Fri, Jan 16, 3:26 PM

This revision is now accepted and ready to land.Fri, Jan 16, 3:26 PM

Closed by commit rG202e3109a9d6: amd64: Fix sys/pcpu.h usage in vmm_host.h and md_var.h (authored by rosenfeld_grumpf.hope-2000.org, committed by markj). · Explain WhySat, Jan 24, 1:55 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG202e3109a9d6: amd64: Fix sys/pcpu.h usage in vmm_host.h and md_var.h.