Page MenuHomeFreeBSD

bhyvectl/amd64: add --get-cpuid-cfg
AcceptedPublic

Authored by rosenfeld_grumpf.hope-2000.org on Jul 26 2025, 11:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 6, 8:01 PM
Unknown Object (File)
Mon, Dec 1, 2:19 AM
Unknown Object (File)
Thu, Nov 27, 2:19 PM
Unknown Object (File)
Tue, Nov 25, 10:51 AM
Unknown Object (File)
Sat, Nov 22, 12:10 PM
Unknown Object (File)
Sat, Nov 22, 12:08 PM
Unknown Object (File)
Mon, Nov 17, 6:39 PM
Unknown Object (File)
Sun, Nov 16, 11:56 PM

Details

Reviewers
markj
Group Reviewers
bhyve
Summary

Add a command to bhyvectl to fetch and print the CPUID configuration
for a VCPU. The CPUID entries, if any, are printed in hex and ASCII. No
pretty-printing of the information is performed.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67933
Build 64816: arc lint + arc unit

Event Timeline

markj added inline comments.
usr.sbin/bhyvectl/amd64/bhyvectl_machdep.c
1927

Where exactly does it get filled in? This looks like it always queries vcpu 0, ignoring the --cpu parameter.

usr.sbin/bhyvectl/amd64/bhyvectl_machdep.c
1927

This is done in vcpu_ioctl() in vmmapi.c, called by vm_get_cpuid() in vmmapi_machdep.c:

int
vcpu_ioctl(struct vcpu *vcpu, u_long cmd, void *arg)
{
	/*
	 * XXX: fragile, handle with care
	 * Assumes that the first field of the ioctl data
	 * is the vcpuid.
	 */
	*(int *)arg = vcpu->vcpuid;
	return (ioctl(vcpu->ctx->fd, cmd, arg));
}
markj added inline comments.
usr.sbin/bhyvectl/amd64/bhyvectl_machdep.c
1927

Right, I forgot about that bit of magic. (I'd rather initialize vvcc_vcpuid = -1 in that case.)

This revision is now accepted and ready to land.Oct 22 2025, 7:22 PM