bhyve: use fbuf defaults when config parsing fails
ClosedPublic
Actions

Authored by rew on Nov 21 2023, 1:41 AM.

Details

Reviewers

corvink
jhb

Group Reviewers

bhyve

Commits

rG0600b575402f: bhyve: verify that user provided fbuf values fall within limits

Summary

Fallback to the framebuffer defaults if atoi() fails to convert the user
provided values for height/width.

..and also remove a couple unused macros that were nearby

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rew created this revision.Nov 21 2023, 1:41 AM

Herald added a reviewer: bhyve. · View Herald TranscriptNov 21 2023, 1:41 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

rew requested review of this revision.Nov 21 2023, 1:41 AM

Harbormaster completed remote builds in B54534: Diff 130365.Nov 21 2023, 1:41 AM

corvink accepted this revision.Nov 21 2023, 7:37 AM

This revision is now accepted and ready to land.Nov 21 2023, 7:37 AM

Hmm, should also reject values smaller than MIN?

TBH, I think it would also be nicer to use strtol and reject values that don't parse cleanly with an error.

address feedback from jhb

This revision now requires review to proceed.Dec 19 2023, 2:09 AM

Harbormaster completed remote builds in B54998: Diff 131543.Dec 19 2023, 2:09 AM

corvink accepted this revision.Dec 19 2023, 7:34 AM

This revision is now accepted and ready to land.Dec 19 2023, 7:34 AM

jhb accepted this revision.Dec 20 2023, 8:27 PM

Closed by commit rG0600b575402f: bhyve: verify that user provided fbuf values fall within limits (authored by rew). · Explain WhyDec 29 2023, 8:39 PM

This revision was automatically updated to reflect the committed changes.

rew added a commit: rG0600b575402f: bhyve: verify that user provided fbuf values fall within limits.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

bhyve.8

4 lines

pci_fbuf.c

33 lines

Diff 131984

View Options

usr.sbin/bhyve/bhyve.8