Page MenuHomeFreeBSD

peterj (Peter Jeremy)
User

Projects

User Details

User Since
Nov 14 2014, 6:00 AM (362 w, 6 d)

Recent Activity

Sep 4 2021

peterj added a comment to D31722: Various fixes for ggatec and ggated.

In general, this is a definite improvement over fixed size buffers (that are actually liable to subtle overruns).

Sep 4 2021, 2:03 AM

Aug 13 2021

peterj added a comment to D26542: [ggated/ggatec] Simplify Gate Handshake..

I have been testing with this code for about a week. Other than the problem I identified in g_gatec_connect(), I haven't had any issues. I haven't specifically tried comparing protocols 0 and 1 but protocol 1 should at worst perform the same as protocol 0 and used only half the TCP connections, making it an overall win.

Aug 13 2021, 10:33 PM

Aug 3 2021

peterj accepted D31318: Fix ggatec request handling.

My comments aside, I believe this is worth committing now. Further improvements are needed but this corrects some clear bugs that are relatively easily triggered.

Aug 3 2021, 9:17 AM

Aug 1 2021

peterj added a comment to D31318: Fix ggatec request handling.

I have been experimenting with zfs send to geli on ggate and had ggatec processes die reporting "ioctl(/dev/ggctl): Cannot allocate memory." and replaced line ggatec.c:134 with the following:

Aug 1 2021, 10:32 AM

Jul 27 2021

peterj added a comment to D31318: Fix ggatec request handling.

I did some experiments with ggate in late 2019 and was concerned about the lack of sanity checking - I managed to get the client system to generate a 1GiB read request, which the server choked on. From my notes at the time:
4659 ggatec CALL recvfrom(0x4,0xffffbffddf08,0x3ffbc000,0x40<MSG_WAITALL>,0,0)
4659 ggatec RET recvfrom -1 errno 14 Bad address
Unfortunately, I didn't keep a record of how I had generated that request. (And for other reasons, I lost interest in ggate at that time).

Jul 27 2021, 10:50 AM

Jul 10 2021

peterj added reviewers for D29181: vmstat: Include seconds in timstamp.: cy, mr.
Jul 10 2021, 7:10 AM

Jul 4 2021

peterj added a comment to D26542: [ggated/ggatec] Simplify Gate Handshake..

Unidirectional data transfer is definitely the worst case for TCP and a single bidirectional socket should work better than two unidirectional sockets whilst using less resources. That said, have you done any performance comparisons between the protocol versions with recent FreeBSD?

Jul 4 2021, 9:36 AM

Jul 2 2021

peterj accepted D30787: rk805: add support for controlling two output pins via gpio interface.

(Sorry for the delay. I thought I'd responded). Then I withdraw my objections. The code itself looks good.

Jul 2 2021, 10:06 AM

Jun 19 2021

peterj requested changes to D30787: rk805: add support for controlling two output pins via gpio interface.

I agree this is only applicable to the RK805. The patch works and provides access to the Rock64 LEDs (pin 0 is red and pin 1 is white, with the LED lit when the output is 0). On the downside, and as noted in the description, there is a LOR with led(9). I'm a bit concerned at adding known new LORs to the code. Are there any options for getting rid of the LOR other than redesigning led(9)?

Jun 19 2021, 12:52 PM

Jun 17 2021

peterj accepted D30786: rk805: add system poweroff support.
Jun 17 2021, 10:49 AM

Apr 9 2021

peterj committed R10:292bcaa4ba28: arm64: Add support for the RK805/RK808 RTC (authored by peterj).
arm64: Add support for the RK805/RK808 RTC
Apr 9 2021, 11:37 PM

Mar 16 2021

peterj committed R10:cdac5f398bf8: nfs: Cleanup dead files (authored by peterj).
nfs: Cleanup dead files
Mar 16 2021, 7:22 PM
peterj closed D29180: nfs: Cleanup dead files.
Mar 16 2021, 7:22 PM
peterj updated the diff for D29180: nfs: Cleanup dead files.

Update ObsoleteFiles with the deleted files.

Mar 16 2021, 8:24 AM

Mar 14 2021

peterj updated the diff for D29180: nfs: Cleanup dead files.

Rather than cleaning up a dead macro, remove a collection of dead files. This has passed a "make buildworld buildkernel" on amd64. I'm currently running a "make tinderbox"

Mar 14 2021, 4:57 AM
peterj retitled D29180: nfs: Cleanup dead files from nfs: Quieten a compiler complaint to nfs: Cleanup dead files.
Mar 14 2021, 4:54 AM
peterj added a comment to D29180: nfs: Cleanup dead files.

I can't find any "amd" port. The only automounter-related ports I can find are sysutils/am-utils, sysutils/automount and sysutils/automounter, none of which seem to reference anything in nfs_common.h. It looks like sys/nfs/nfs_common.h, sys/nfsserver/nfsm_subs.h and sys/nfsclient/nfsm_subs.h are all unreferenced - I shall try another "make universe" to check.

Mar 14 2021, 12:13 AM

Mar 12 2021

peterj committed R10:07564e176201: arm64: Add support for the RK805/RK808 RTC (authored by peterj).
arm64: Add support for the RK805/RK808 RTC
Mar 12 2021, 10:07 PM
peterj closed D22692: Add support for the RK805/RK808 RTC.
Mar 12 2021, 10:07 PM

Mar 10 2021

peterj requested review of D29181: vmstat: Include seconds in timstamp..
Mar 10 2021, 8:43 AM
peterj updated the diff for D29180: nfs: Cleanup dead files.

Replace diff to include more context

Mar 10 2021, 8:39 AM
peterj requested review of D29180: nfs: Cleanup dead files.
Mar 10 2021, 8:32 AM

Mar 9 2021

peterj updated the diff for D22692: Add support for the RK805/RK808 RTC.

Added context, no changes.

Mar 9 2021, 10:58 AM
peterj requested review of D29141: Add USB identifier for TI MSP430 LaunchPad.
Mar 9 2021, 10:48 AM
peterj updated the diff for D22692: Add support for the RK805/RK808 RTC.

Updated to account for previous comments:

Mar 9 2021, 10:45 AM
peterj commandeered D22692: Add support for the RK805/RK808 RTC.

There hasn't been any response by andrew to previous comments and I have a revised patch.

Mar 9 2021, 10:37 AM
peterj abandoned D29140: Add support for the RK805/RK808 RTC.
Mar 9 2021, 10:35 AM
peterj added a comment to D22692: Add support for the RK805/RK808 RTC.

Since I don't seem to be able to update the patch here, I've created D29140 as a replacement that addresses all the comments above.

Mar 9 2021, 10:18 AM
peterj requested review of D29140: Add support for the RK805/RK808 RTC.
Mar 9 2021, 10:16 AM

Mar 6 2021

peterj added a comment to D22692: Add support for the RK805/RK808 RTC.
In D22692#527481, @mmel wrote:

Most boards don't have a battery connected. What happens in this case? I don't see any validity detection in this code

Mar 6 2021, 6:15 AM

Dec 27 2020

peterj committed R9:0a83c0b2a9ea: Update my PGP key. (authored by peterj).
Update my PGP key.
Dec 27 2020, 4:18 AM

Oct 25 2019

peterj committed rS354094: Fix use of uninitialised variable..
Fix use of uninitialised variable.
Oct 25 2019, 7:38 PM

Oct 4 2019

peterj added a comment to D21883: Fix interface between nfsclient and vnode pager..

This patch fixes a reproduceable NFS deadlock (deadlres_td_sleep_q panic) I was getting on my diskless Rock64 with recent kernels.

Oct 4 2019, 4:09 AM

May 3 2019

peterj committed rS347072: MFC: r346266.
MFC: r346266
May 3 2019, 11:07 PM
peterj committed rS347071: MFC: r346266.
MFC: r346266
May 3 2019, 11:06 PM
peterj committed rS347070: MFC: r346265.
MFC: r346265
May 3 2019, 11:03 PM
peterj committed rS347069: MFC: r346265.
MFC: r346265
May 3 2019, 11:02 PM
peterj committed rS347068: MFC r343953:.
MFC r343953:
May 3 2019, 10:57 PM
peterj committed rS347067: MFC r343953:.
MFC r343953:
May 3 2019, 10:55 PM

Apr 16 2019

peterj committed rS346266: Specify correct Ethernet phy for RPI-B.
Specify correct Ethernet phy for RPI-B
Apr 16 2019, 9:45 AM
peterj committed rS346265: Fix cpufreq(4) on RPI-B.
Fix cpufreq(4) on RPI-B
Apr 16 2019, 9:43 AM

Feb 10 2019

peterj committed rS343953: Replace calls to sin(x) and cos(x) with a single call to sincos()..
Replace calls to sin(x) and cos(x) with a single call to sincos().
Feb 10 2019, 8:46 AM

Jul 18 2018

peterj committed rS336448: Retrospectively document SVN branch point for stable-10 and its releases..
Retrospectively document SVN branch point for stable-10 and its releases.
Jul 18 2018, 9:32 AM
peterj closed D16263: Retrospectively document SVN branch point for stable-10 and its releases..
Jul 18 2018, 9:32 AM

Jul 17 2018

peterj committed rS336409: Retrospectively document SVN branch points for stable-11 and its releases..
Retrospectively document SVN branch points for stable-11 and its releases.
Jul 17 2018, 11:44 AM
peterj closed D16264: Retrospectively document SVN branch points for stable-11 and its releases..
Jul 17 2018, 11:44 AM
peterj committed rS336406: Retrospectively document SVN branch point for stable-11.
Retrospectively document SVN branch point for stable-11
Jul 17 2018, 11:35 AM
peterj closed D16262: Retrospectively document SVN branch point for stable-11.
Jul 17 2018, 11:35 AM

Jul 14 2018

peterj added a reviewer for D16264: Retrospectively document SVN branch points for stable-11 and its releases.: jhb.
Jul 14 2018, 4:24 AM
peterj added a reviewer for D16263: Retrospectively document SVN branch point for stable-10 and its releases.: jhb.
Jul 14 2018, 4:23 AM
peterj added a reviewer for D16262: Retrospectively document SVN branch point for stable-11: jhb.
Jul 14 2018, 4:23 AM
peterj created D16264: Retrospectively document SVN branch points for stable-11 and its releases..
Jul 14 2018, 2:44 AM
peterj created D16263: Retrospectively document SVN branch point for stable-10 and its releases..
Jul 14 2018, 2:40 AM
peterj created D16262: Retrospectively document SVN branch point for stable-11.
Jul 14 2018, 2:38 AM

Mar 26 2018

peterj committed rD51516: Update PGP key expiry dates for peterj.
Update PGP key expiry dates for peterj
Mar 26 2018, 8:07 AM

Jan 30 2017

peterj abandoned D9346: 1) Add new rtld option to display error messages.
Jan 30 2017, 9:28 AM
peterj added a comment to D9346: 1) Add new rtld option to display error messages.

Based on kib's comments, I'll withdraw this revision. r312984 is similar functionality.

Jan 30 2017, 8:55 AM
peterj committed rS312984: Extend LD_UTRACE by also generating utrace(2) log events for runtime linker.
Extend LD_UTRACE by also generating utrace(2) log events for runtime linker
Jan 30 2017, 8:38 AM
peterj closed D9347: Log and report rtld error messages via utrace(2)/ktrace(1). by committing rS312984: Extend LD_UTRACE by also generating utrace(2) log events for runtime linker.
Jan 30 2017, 8:38 AM

Jan 26 2017

peterj retitled D9347: Log and report rtld error messages via utrace(2)/ktrace(1). from to Log and report rtld error messages via utrace(2)/ktrace(1)..
Jan 26 2017, 7:27 AM
peterj retitled D9346: 1) Add new rtld option to display error messages from to 1) Add new rtld option to display error messages.
Jan 26 2017, 7:24 AM

Jan 24 2017

peterj added a comment to D9306: Add LOGDIR option to redirect "make universe" output to a different directory..

Is there any particular reason not to just put them in the build output directory?

Jan 24 2017, 9:39 AM
peterj updated the diff for D9306: Add LOGDIR option to redirect "make universe" output to a different directory..

Change "LOGDIR" to "UNIVERSE_LOGDIR" to reduce risk of clashes.

Jan 24 2017, 9:39 AM

Jan 23 2017

peterj retitled D9306: Add LOGDIR option to redirect "make universe" output to a different directory. from to Add LOGDIR option to redirect "make universe" output to a different directory..
Jan 23 2017, 6:51 PM

Jun 27 2016

peterj committed rD49009: Update my PGP key..
Update my PGP key.
Jun 27 2016, 8:30 AM

May 12 2015

peterj added a comment to D2515: Increate BUFSIZ to 8192.

I've been bitten in the past by a buffer size change causing unexpected breakage (bin/144446) and would be wary of making this change without extensive testing. The claimed benefit is improved performance - in which case, I'd expect more justification than a single md5 and sha256 test. What does ministat(1) report on 3-5 runs?

May 12 2015, 8:40 AM