prometheus_sysctl_exporter: Replace magic numbers with identifiers.
ClosedPublic
Actions

Authored by peterj on Apr 25 2023, 11:03 AM.

Tags

None

Referenced Files

	F139393657: D39797.id121066.diff
	Thu, Dec 11, 3:29 PM

	Unknown Object (File)
	Sat, Dec 6, 10:11 PM

	Unknown Object (File)
	Fri, Nov 28, 2:19 AM

	Unknown Object (File)
	Thu, Nov 27, 10:14 PM

	Unknown Object (File)
	Sun, Nov 23, 10:04 AM

	Unknown Object (File)
	Thu, Nov 20, 8:04 PM

	Unknown Object (File)
	Thu, Nov 13, 12:30 PM

	Unknown Object (File)
	Nov 11 2025, 10:39 PM

View All 95 Files

Subscribers

imp

Details

Reviewers

asomers

Commits

rGb9600db494a0: prometheus_sysctl_exporter: Replace magic numbers with identifiers.

Summary

Identifiers make it clearer what is going on and makes it easier to
find consumers of sysctl functionality.

No functional change.

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

peterj created this revision.Apr 25 2023, 11:03 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 25 2023, 11:03 AM

peterj requested review of this revision.Apr 25 2023, 11:03 AM

Harbormaster completed remote builds in B51174: Diff 120993.Apr 25 2023, 11:03 AM

asomers accepted this revision.Apr 25 2023, 1:49 PM

This revision is now accepted and ready to land.Apr 25 2023, 1:49 PM

Closed by commit rGb9600db494a0: prometheus_sysctl_exporter: Replace magic numbers with identifiers. (authored by peterj). · Explain WhyApr 26 2023, 8:30 AM

This revision was automatically updated to reflect the committed changes.

peterj added a commit: rGb9600db494a0: prometheus_sysctl_exporter: Replace magic numbers with identifiers..

Revision Contents
Changeset List

Path

Size

usr.sbin/

prometheus_sysctl_exporter/

prometheus_sysctl_exporter.c

18 lines

Diff 121066

View Options

usr.sbin/prometheus_sysctl_exporter/prometheus_sysctl_exporter.c

prometheus_sysctl_exporter: Replace magic numbers with identifiers.ClosedPublicActions