Page MenuHomeFreeBSD

Add ggated rc script
ClosedPublic

Authored by jo_bruelltuete.com on Aug 29 2021, 1:15 AM.

Details

Summary

simple rc script to start ggated. seems useful to have.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jo_bruelltuete.com created this revision.
asomers requested changes to this revision.Oct 29 2021, 6:38 PM

Sorry I didn't notice when you first put this review up. It looks good, except:

  • Needs a Makefile entry
  • Need to trim the trailing newline.
This revision now requires changes to proceed.Oct 29 2021, 6:38 PM

Need to trim the trailing newline

Do you mean the empty last line of the file?
The other scripts in this directory have an empty last line as well.

Need to trim the trailing newline

Do you mean the empty last line of the file?
The other scripts in this directory have an empty last line as well.

Actually scratch that... i think my editor was playing tricks on me...

hm... prob need a default ggated_enable=NO somewher.
as is, this is quite spammy:
Nov 3 01:21:46 host root[2237]: /etc/rc: WARNING: $ggated_enable is not set properly - see rc.conf(5).

hi @peterj, thanks for taking a look. feel free to commit (i dont have permissions).

This revision is now accepted and ready to land.Feb 28 2022, 4:10 AM
This revision was automatically updated to reflect the committed changes.