Page MenuHomeFreeBSD

nfs: Cleanup dead files
ClosedPublic

Authored by peterj on Mar 10 2021, 8:32 AM.

Details

Summary

These files are no longer used by the FreeBSD base system. They were being used by the amd port but that has also been deleted.

Test Plan

"make universe"

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

peterj created this revision.

Replace diff to include more context

Do whatever you want with it.
Since the macro is no longer used
anywhere in /usr/src and *probably*
not used by any port, you could
just delete it.

The main port that used these .h
files from the old NFS code was
the amd automounter, but it was
supposed to go away.
I don't have an up to date /usr/ports
handy to see if it is still there?

I can't find any "amd" port. The only automounter-related ports I can find are sysutils/am-utils, sysutils/automount and sysutils/automounter, none of which seem to reference anything in nfs_common.h. It looks like sys/nfs/nfs_common.h, sys/nfsserver/nfsm_subs.h and sys/nfsclient/nfsm_subs.h are all unreferenced - I shall try another "make universe" to check.

Yes. My understanding was that the "amd"
port was deprecated.
If it is gone now, then those .h files are probably
cruft.

peterj retitled this revision from nfs: Quieten a compiler complaint to nfs: Cleanup dead files.Sun, Mar 14, 4:54 AM
peterj edited the summary of this revision. (Show Details)
peterj edited the test plan for this revision. (Show Details)

Rather than cleaning up a dead macro, remove a collection of dead files. This has passed a "make buildworld buildkernel" on amd64. I'm currently running a "make tinderbox"

Looks good to me. Thanks for doing this.
It has been on my todo list at times, but
slipped through the cracks.

At some point, they probably should go
in Obsolete files, since they are copied
to /usr/include during installation.

This revision is now accepted and ready to land.Sun, Mar 14, 3:17 PM

Update ObsoleteFiles with the deleted files.

This revision now requires review to proceed.Tue, Mar 16, 8:24 AM
This revision is now accepted and ready to land.Tue, Mar 16, 2:23 PM
This revision was automatically updated to reflect the committed changes.