Page MenuHomeFreeBSD
Differential D29180

nfs: Cleanup dead files
ClosedPublic
Actions

Authored by peterj on Mar 10 2021, 8:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 29, 12:50 PM
Unknown Object (File)
Oct 10 2024, 8:21 AM
Unknown Object (File)
Oct 10 2024, 8:21 AM
Unknown Object (File)
Oct 10 2024, 8:21 AM
Unknown Object (File)
Oct 10 2024, 8:21 AM
Unknown Object (File)
Oct 10 2024, 8:21 AM
Unknown Object (File)
Oct 10 2024, 8:21 AM
Unknown Object (File)
Oct 10 2024, 8:07 AM
View All Files
Subscribers
None

Details

Reviewers
rmacklem
Commits
rGcdac5f398bf8: nfs: Cleanup dead files
Summary

These files are no longer used by the FreeBSD base system. They were being used by the amd port but that has also been deleted.

Test Plan

"make universe"

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

peterj requested review of this revision.Mar 10 2021, 8:32 AM
peterj created this revision.
peterj updated this revision to Diff 85461.Mar 10 2021, 8:38 AM

Replace diff to include more context

rmacklem added a comment.Mar 10 2021, 3:26 PM

Do whatever you want with it.
Since the macro is no longer used
anywhere in /usr/src and *probably*
not used by any port, you could
just delete it.

The main port that used these .h
files from the old NFS code was
the amd automounter, but it was
supposed to go away.
I don't have an up to date /usr/ports
handy to see if it is still there?

peterj added a comment.Mar 14 2021, 12:13 AM

I can't find any "amd" port. The only automounter-related ports I can find are sysutils/am-utils, sysutils/automount and sysutils/automounter, none of which seem to reference anything in nfs_common.h. It looks like sys/nfs/nfs_common.h, sys/nfsserver/nfsm_subs.h and sys/nfsclient/nfsm_subs.h are all unreferenced - I shall try another "make universe" to check.

rmacklem added a comment.Mar 14 2021, 3:05 AM

Yes. My understanding was that the "amd"
port was deprecated.
If it is gone now, then those .h files are probably
cruft.

peterj retitled this revision from nfs: Quieten a compiler complaint to nfs: Cleanup dead files.Mar 14 2021, 4:54 AM
peterj edited the summary of this revision. (Show Details)
peterj edited the test plan for this revision. (Show Details)
peterj updated this revision to Diff 85707.Mar 14 2021, 4:57 AM

Rather than cleaning up a dead macro, remove a collection of dead files. This has passed a "make buildworld buildkernel" on amd64. I'm currently running a "make tinderbox"

rmacklem accepted this revision.Mar 14 2021, 3:17 PM

Looks good to me. Thanks for doing this.
It has been on my todo list at times, but
slipped through the cracks.

At some point, they probably should go
in Obsolete files, since they are copied
to /usr/include during installation.

This revision is now accepted and ready to land.Mar 14 2021, 3:17 PM
peterj updated this revision to Diff 85823.Mar 16 2021, 8:24 AM

Update ObsoleteFiles with the deleted files.

This revision now requires review to proceed.Mar 16 2021, 8:24 AM
rmacklem accepted this revision.Mar 16 2021, 2:23 PM

Looks fine to me.

This revision is now accepted and ready to land.Mar 16 2021, 2:23 PM
Closed by commit rGcdac5f398bf8: nfs: Cleanup dead files (authored by peterj). · Explain WhyMar 16 2021, 7:22 PM
This revision was automatically updated to reflect the committed changes.
peterj added a commit: rGcdac5f398bf8: nfs: Cleanup dead files.

Revision Contents
Changeset List

Diff 85707

View Options

sys/nfs/nfs_common.h

Loading...
View Options

sys/nfsclient/nfsm_subs.h

Loading...
View Options

sys/nfsclient/nlminfo.h

Loading...
View Options

sys/nfsserver/nfs_fha_old.h

Loading...
View Options

sys/nfsserver/nfsm_subs.h

Loading...
View Options

sys/nfsserver/nfsrvcache.h

Loading...