make buildkernel passes
Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 60252 Build 57136: arc lint + arc unit
Event Timeline
Some other cleanups to consider as separate commits: Just use the userspace version of NLMSG_ALIGNTO and NLMSG_ALIGN always (so move them above the #ifndef _KERNEL). Also, replace roundup2() with just using __align_up() from <sys/cdefs.h> unconditionally.
I'm also not convinced that NLMSG_HDRLEN isn't in practice the same for both userspace and the kernel.
sys/netlink/netlink.h | ||
---|---|---|
216 | sizeof() already returns a size_t, so you can just remove this cast instead | |
229 | I'm not sure you need this cast either |
I'm fine with doing all this at once, though you might want to update the log to mention using __align_up and reducing duplication, etc.
sys/netlink/netlink.h | ||
---|---|---|
229 | You can use tabs to align the macro value now while you are here. |
Let’s make sure that the constants /macro still has the same type as in Linux and check that, for example, net/bird2 compiles without additional warnings after this change