Some other cleanups to consider as separate commits: Just use the userspace version of NLMSG_ALIGNTO and NLMSG_ALIGN always (so move them above the #ifndef _KERNEL). Also, replace roundup2() with just using __align_up() from <sys/cdefs.h> unconditionally.

I'm also not convinced that NLMSG_HDRLEN isn't in practice the same for both userspace and the kernel.

sys/netlink/netlink.h
213	sizeof() already returns a size_t, so you can just remove this cast instead
226	I'm not sure you need this cast either

Address comments

Harbormaster completed remote builds in B60285: Diff 145749.Oct 31 2024, 4:40 PM

arrowd retitled this revision from netlink: Cast to (size_t) instead of (int) in NLMSG_HDRLEN and _NLMSG_LEN to netlink: Do not cast to int in NLMSG_HDRLEN and _NLMSG_LEN.Oct 31 2024, 4:49 PM

I'm fine with doing all this at once, though you might want to update the log to mention using __align_up and reducing duplication, etc.

sys/netlink/netlink.h
226	You can use tabs to align the macro value now while you are here.

This revision is now accepted and ready to land.Oct 31 2024, 4:52 PM

In D47333#1080149, @jhb wrote:

I'm fine with doing all this at once, though you might want to update the log to mention using __align_up and reducing duplication, etc.

I did it as three commits, see the "Commits" tab.

Align with tabs

This revision now requires review to proceed.Oct 31 2024, 4:58 PM

Harbormaster completed remote builds in B60288: Diff 145757.Oct 31 2024, 4:58 PM

Ah, ok. I tend to upload individual commits as a stack. Still LGTM, thanks!

Let’s make sure that the constants /macro still has the same type as in Linux and check that, for example, net/bird2 compiles without additional warnings after this change