Differential D48768

ctld: Write the pidfile once after forking
ClosedPublic
Actions

Authored by jhb on Jan 31 2025, 8:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 31, 8:30 PM

	Unknown Object (File)
	Tue, May 12, 5:47 PM

	Unknown Object (File)
	May 8 2026, 9:09 PM

	Unknown Object (File)
	May 6 2026, 4:46 AM

	Unknown Object (File)
	May 1 2026, 11:57 PM

	Unknown Object (File)
	Apr 29 2026, 11:24 AM

	Unknown Object (File)
	Apr 29 2026, 11:14 AM

	Unknown Object (File)
	Apr 26 2026, 3:18 AM

View All 89 Files

Subscribers

Details

Reviewers

asomers
mav
trasz

Commits

rGf1c08b611124: ctld: Write the pidfile once after forking
rG7bad3c3e5f1c: ctld: Write the pidfile once after forking

Summary

Don't rewrite the pidfile each time main_loop is called.

PR: 284282
Reported by: asomers
Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 31 2025, 8:16 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 31 2025, 8:16 PM

Harbormaster completed remote builds in B62173: Diff 150289.Jan 31 2025, 8:16 PM

jhb requested review of this revision.Jan 31 2025, 8:16 PM

jhb added a parent revision: D48767: libnvmf: Add nvmf_nqn_valid_strict() function.

jhb added a child revision: D48769: ctld: Refactor out functions to parse dscp and pcp properties.

Thank you!

This revision is now accepted and ready to land.Jan 31 2025, 10:09 PM

Closed by commit rG7bad3c3e5f1c: ctld: Write the pidfile once after forking (authored by jhb). · Explain WhyFeb 5 2025, 7:55 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG7bad3c3e5f1c: ctld: Write the pidfile once after forking.

jhb added a commit: rGf1c08b611124: ctld: Write the pidfile once after forking.Jan 27 2026, 6:44 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

8 lines

Diff 150564

usr.sbin/ctld/ctld.c

Loading...