ctld: Add abstractions to support multiple target protocols
Needs ReviewPublic
Actions

Authored by jhb on Jan 31 2025, 8:16 PM.

Details

Reviewers

asomers
mav
trasz

Summary

This is a prerequisite for adding NVMe over Fabrics support.

A new target-level protocol type is associated with a 'struct
target_ops' which contains methods for various protocol-specific
options such as populating requests to add and remove ctl(4) ports.

While here, move some iSCSI-only functions out of ctld.c and kernel.c
into iscsi.c and make discovery.c, iscsi.c, and login.c which are all
iSCSI-specific conditional on MK_ISCSI.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62639
Build 59523: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 31 2025, 8:16 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 31 2025, 8:16 PM

jhb requested review of this revision.Jan 31 2025, 8:16 PM

Harbormaster completed remote builds in B62177: Diff 150293.Jan 31 2025, 8:16 PM

jhb added a parent revision: D48771: ctld: Move kernel_limits into login.c where it is used.Jan 31 2025, 8:16 PM

jhb added a child revision: D48773: ctld: Add support for NVMe over Fabrics.

Rebase after fixing previous patch

Harbormaster completed remote builds in B62206: Diff 150367.Feb 1 2025, 2:19 PM

asomers added inline comments.Feb 2 2025, 5:44 PM

usr.sbin/ctld/ctld.h
116	Is there any reason why this couldn't be an enum?
139	Since it's actually allocating and returning a different string, this function isn't really a validator. How about "normalize_target_name" instead?
usr.sbin/ctld/kernel.c
568–569	Frankly, I think that all of these commented-out sections should just be deleted. It's highly likely that they don't all compile anymore.