Differential D48770

ctld: Don't specify the TCP port for default iSCSI portal group sockets
ClosedPublic
Actions

Authored by jhb on Jan 31 2025, 8:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jul 27, 4:37 AM

	Unknown Object (File)
	Sun, Jul 26, 3:47 PM

	Unknown Object (File)
	Thu, Jul 23, 6:49 AM

	Unknown Object (File)
	Mon, Jul 20, 7:56 AM

	Unknown Object (File)
	Sat, Jul 4, 12:24 AM

	Unknown Object (File)
	May 14 2026, 11:20 AM

	Unknown Object (File)
	May 12 2026, 4:28 PM

	Unknown Object (File)
	May 12 2026, 1:55 PM

View All 75 Files

Subscribers

Details

Reviewers

asomers
mav
trasz

Commits

rG90d5638f97b3: ctld: Don't specify the TCP port for default iSCSI portal group sockets
rG0a3e74f55aed: ctld: Don't specify the TCP port for default iSCSI portal group sockets

Summary

portal_group_add_listen already uses the default TCP port if no port
is specified so this was redundant.

Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 31 2025, 8:16 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 31 2025, 8:16 PM

jhb requested review of this revision.Jan 31 2025, 8:16 PM

Harbormaster completed remote builds in B62175: Diff 150291.Jan 31 2025, 8:16 PM

jhb added a parent revision: D48769: ctld: Refactor out functions to parse dscp and pcp properties.Jan 31 2025, 8:16 PM

jhb added a child revision: D48771: ctld: Move kernel_limits into login.c where it is used.

asomers accepted this revision.Jan 31 2025, 10:20 PM

This revision is now accepted and ready to land.Jan 31 2025, 10:20 PM

Closed by commit rG0a3e74f55aed: ctld: Don't specify the TCP port for default iSCSI portal group sockets (authored by jhb). · Explain WhyFeb 5 2025, 7:56 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG0a3e74f55aed: ctld: Don't specify the TCP port for default iSCSI portal group sockets.

jhb added a commit: rG90d5638f97b3: ctld: Don't specify the TCP port for default iSCSI portal group sockets.Jan 27 2026, 6:44 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

4 lines

Diff 150566

usr.sbin/ctld/ctld.c

Loading...