Page MenuHomeFreeBSD
Feed Advanced Search

Yesterday

asomers accepted D38418: ping6: Use errx to avoid appending a specious error message.
Tue, Feb 7, 7:44 PM

Sat, Feb 4

asomers accepted D38379: FIOSEEKHOLE/FIOSEEKDATA: correct constistency for bmap-based implementation.

LGTM and it fixes the tests for UFS, though I'm not an expert in this area. The problem with fusefs has a different cause; I'll discuss on bugzilla.

Sat, Feb 4, 5:02 PM

Fri, Feb 3

asomers accepted D38375: ccr,ccp: Fix argument order to sglist_append_vmpages..
Fri, Feb 3, 6:59 PM

Fri, Jan 27

asomers committed rG0811d18fea91: cal: don't print terminal control characters unless stdout is a TTY (authored by asomers).
cal: don't print terminal control characters unless stdout is a TTY
Fri, Jan 27, 7:32 PM
asomers committed rG8b7b81fd64ec: Switch wg(4) to the new if_clone KPI (authored by asomers).
Switch wg(4) to the new if_clone KPI
Fri, Jan 27, 7:29 PM
asomers committed rG704bfe6dbfcb: fsx: more consistent debug output with -[RWU] (authored by asomers).
fsx: more consistent debug output with -[RWU]
Fri, Jan 27, 7:29 PM
asomers committed rG8a8d695deea0: ping(8): man page cleanup (authored by jlduran_gmail.com).
ping(8): man page cleanup
Fri, Jan 27, 7:29 PM
asomers committed rGae380bb8864f: fsx: bounds check the inputs (authored by asomers).
fsx: bounds check the inputs
Fri, Jan 27, 7:29 PM
asomers committed rGd3deff397d7b: Add test cases for ping with IP options in the response (authored by asomers).
Add test cases for ping with IP options in the response
Fri, Jan 27, 7:29 PM
asomers committed rG6d28cb5486b8: improvements to cap_sysctl.3 (authored by asomers).
improvements to cap_sysctl.3
Fri, Jan 27, 7:28 PM
asomers committed rG1961075a6972: Allow any user to read the NFS stats, for example with nfsstat(1). (authored by asomers).
Allow any user to read the NFS stats, for example with nfsstat(1).
Fri, Jan 27, 5:12 PM
asomers committed rGc8c74bcbe973: document first appearance of fhlink et al (authored by asomers).
document first appearance of fhlink et al
Fri, Jan 27, 3:41 PM

Mon, Jan 23

asomers committed R11:a8806c5adaab: net-mgmt/nfs-exporter: disable on powerpc (authored by asomers).
net-mgmt/nfs-exporter: disable on powerpc
Mon, Jan 23, 3:16 PM

Sat, Jan 21

asomers committed R11:15a0ee651699: security/vuxml: register shells/fish vulnerability (authored by asomers).
security/vuxml: register shells/fish vulnerability
Sat, Jan 21, 10:43 PM
asomers added a comment to D38130: ctlstat: fix -P with disassociated LUNs..
In D38130#866489, @mav wrote:

I suppose that request would give you all traffic of the LUNs accessible through that target, even one going though different targets. As alternative, CTL collects per-port statistics, that would closer match targets, if desired, but then without separation between different LUNs.

Sat, Jan 21, 12:48 AM

Fri, Jan 20

asomers added a comment to D38130: ctlstat: fix -P with disassociated LUNs..

@mav I think reporting a schema like this would work . I need to prototype it first to be sure, though:

Fri, Jan 20, 9:05 PM
asomers added a reverting change for rG2c24ad3377a6: ifconfig: abort if loading a module fails other than for ENOENT: rG520590881667: Revert "ifconfig: abort if loading a module fails other than for ENOENT".
Fri, Jan 20, 5:25 PM
asomers added a reverting change for D37873: ifconfig: abort if loading a module fails other than for ENOENT: rG520590881667: Revert "ifconfig: abort if loading a module fails other than for ENOENT".
Fri, Jan 20, 5:25 PM
asomers committed rG520590881667: Revert "ifconfig: abort if loading a module fails other than for ENOENT" (authored by asomers).
Revert "ifconfig: abort if loading a module fails other than for ENOENT"
Fri, Jan 20, 5:25 PM
asomers added a comment to D38130: ctlstat: fix -P with disassociated LUNs..

Note that ctlstat's prometheus functionality has already been MFCed to stable/13. However, it wasn't included in 13.1. So there's still time to change the output schema if we must, without breaking compatibility with any releases.

Fri, Jan 20, 2:18 AM
asomers added a comment to D38130: ctlstat: fix -P with disassociated LUNs..
In D38130#866209, @mav wrote:

I've never before looked on this code, but all this targdata.targets[lun] logic looks wrong to me. Any LUN may be mapped into multiple different ports, think that this code does not allow. LUNs not mapped into any port is only a one minor case of generally broken design. I have no idea what data this Prometheus is expecting to receive, but right now it obviously does not receive the full picture. This particular patch is not bad, but it just does not fix whole problem, only a minor part.

Fri, Jan 20, 2:12 AM

Thu, Jan 19

asomers requested review of D38130: ctlstat: fix -P with disassociated LUNs..
Thu, Jan 19, 11:17 PM

Sat, Jan 14

asomers committed R11:ce36d72b308b: devel/fsx: new port (authored by asomers).
devel/fsx: new port
Sat, Jan 14, 9:39 PM
asomers added a comment to D38053: ping: Add ATF-Python tests.

This looks like a good start. I'm not a fan of the methodize stuff, though. I think it makes the tests harder to read and harder to search. Is there a way to parameterize the tests without using methodize, even if it becomes slightly more verbose?

Sat, Jan 14, 3:10 PM ยท Python

Fri, Jan 13

asomers committed rG92e978439f0c: cal: don't print terminal control characters unless stdout is a TTY (authored by asomers).
cal: don't print terminal control characters unless stdout is a TTY
Fri, Jan 13, 9:31 PM
asomers closed D38045: cal: don't print terminal control characters unless stdout is a TTY.
Fri, Jan 13, 9:30 PM
asomers requested review of D38045: cal: don't print terminal control characters unless stdout is a TTY.
Fri, Jan 13, 8:22 PM
asomers committed R11:0de11ff4ffa5: sysutils/zrepl: warn of impending SSL certificate expiration (authored by asomers).
sysutils/zrepl: warn of impending SSL certificate expiration
Fri, Jan 13, 8:11 PM

Wed, Jan 11

asomers accepted D38021: pytest: Add an IPv4 loopback address.

Seems reasonable to me.

Wed, Jan 11, 2:07 PM
asomers added a comment to D37971: testing: change python ATF cleanup handlers to be more pythonic.
In D37971#863583, @ngie wrote:

I hate to be a wet blanket, but a lot of the code seems to go against design decisions made in pytest around fixtures, extendability, etc.
In particular, just glancing at this commit, it seems to rely on J-Unit-like structure (used in unittest), which is not strictly adhered to in pytest.
FWIW, I honestly think integration should be the other way around: ATF should integrate into pytest, not pytest should integrate into ATF. If things were done in that manner and we used the JUnit output format (supported natively in pytest), we could move away from Kyua to a framework that is less bespoke, has a ton less boilerplate than ATF, has better developer and user experience, and has better opensource mindshare than ATF/Kyua.
The main value ATF/Kyua provides (IMHO) is the ability to integrate in tests from NetBSD and a format to express legacy tests in, which gave FreeBSD a great head start in terms of CI/testability. Other than that, it's kind of a kludgy framework.

Wed, Jan 11, 3:54 AM

Tue, Jan 10

asomers committed rGdb1cdf2fabfe: libcasper.3: document cap_init's single-threaded program requirement (authored by asomers).
libcasper.3: document cap_init's single-threaded program requirement
Tue, Jan 10, 7:54 PM
asomers closed D38020: libcasper.3: document cap_init's single-threaded program requirement.
Tue, Jan 10, 7:54 PM
asomers added inline comments to D38020: libcasper.3: document cap_init's single-threaded program requirement.
Tue, Jan 10, 7:52 PM
asomers requested review of D38020: libcasper.3: document cap_init's single-threaded program requirement.
Tue, Jan 10, 7:03 PM

Mon, Jan 9

asomers committed rG2c24ad3377a6: ifconfig: abort if loading a module fails other than for ENOENT (authored by asomers).
ifconfig: abort if loading a module fails other than for ENOENT
Mon, Jan 9, 6:57 PM
asomers closed D37873: ifconfig: abort if loading a module fails other than for ENOENT.
Mon, Jan 9, 6:57 PM
asomers closed D37740: wg(4): switch to the new if_clone interface.
Mon, Jan 9, 6:56 PM
asomers committed rGeb3f9a7aece9: Switch wg(4) to the new if_clone KPI (authored by asomers).
Switch wg(4) to the new if_clone KPI
Mon, Jan 9, 6:56 PM

Jan 6 2023

asomers committed rGda303f5fd4ee: fsx: more consistent debug output with -[RWU] (authored by asomers).
fsx: more consistent debug output with -[RWU]
Jan 6 2023, 8:50 PM
asomers committed rG3f8ca7a22ed9: fsx: bounds check the inputs (authored by asomers).
fsx: bounds check the inputs
Jan 6 2023, 5:57 PM

Jan 5 2023

asomers accepted D37950: <sys/sysctl.h>: Reduce overly broad header pollution..

LGTM. It looks like I included sys/systm.h because an earlier, pre-phabricator version of the change included a panic() within cmp_sysctl_oid, but then I forgot to revert the header change.

Jan 5 2023, 3:40 AM

Jan 2 2023

asomers added a comment to D37873: ifconfig: abort if loading a module fails other than for ENOENT.
In D37873#861872, @jhb wrote:

Is this related to the issues you had with using if_wg(4) interfaces in jails?

Jan 2 2023, 10:58 PM
asomers committed rG8eb4df948711: ping(8): man page cleanup (authored by jlduran_gmail.com).
ping(8): man page cleanup
Jan 2 2023, 1:39 AM

Jan 1 2023

asomers added a comment to D35881: new test: after destroying a jail, its vnet interfaces should be visible by host.

Since the test is no longer vnet-specific, don't forget to adjust the commit message. Also, does the polling loop still exhibit problems with the non-vnet version of the test? We've got to get rid of that "sleep 5".

Jan 1 2023, 11:32 PM
asomers added a comment to D37923: testing: handling non-root users with VNETs in pytests..

I find this confusing. It's weird that Kyua handles some of the test case isolation, and Python handles other parts. It also means that an unprivileged user won't be able to simply type "kyua test ..." and expect the unprivileged test cases to work. It seems like either the vnet stuff needs to be moved up into Kyua itself, or the privilege dropping needs to be moved down out of the runner and into the test class. In the latter case, the test case would still have a "require.user root", but could use some other decorator or just the class setup to drop privileges.

Jan 1 2023, 11:20 PM

Dec 31 2022

asomers accepted D37876: ping_tests: Introduce a script to test ping.
Dec 31 2022, 3:14 AM

Dec 30 2022

asomers requested changes to D37876: ping_tests: Introduce a script to test ping.
Dec 30 2022, 11:16 PM
asomers added a comment to D37902: testing: add python test examples..

A "test_case_cleanup" method would work. But it would be more Pythonic if it were a teardown method. Would that be possible?

Dec 30 2022, 7:09 PM
asomers added a comment to D37876: ping_tests: Introduce a script to test ping.

Ahh, you're correct about the cleanup directory. I misremembered that.

Dec 30 2022, 5:48 PM
asomers added a comment to D37902: testing: add python test examples..

This looks great. I especially like the ability to parameterize test cases, which isn't easy with atf-sh-api or atf-c-api. What about cleanup? I think atf-python tests need to do that differently, right? It would be good to add an example for that.

Dec 30 2022, 5:08 PM
asomers added a comment to D36241: freebsd-update(8): add new command to 'check' for available updates only.

The only problem I have with this new feature is that it is 75% redundant with updatesready. I think that having two so-similar features will confuse users. Is there any way to get the benefits of both, while not adding any new commands?

Dec 30 2022, 4:33 PM

Dec 26 2022

asomers added a comment to D37876: ping_tests: Introduce a script to test ping.

I think this looks really great. I assume you have a few extra test cases that you're planning to add to ping_test.sh? Personally, I don't have strong opinions about whether to use atf-sh or pytest, as long as you can get the cleanup and metadata correct. And don't forget that you'll need to add injection.py to ObsoleteFiles.mk, or else rename pinger.py to injection.py.

Dec 26 2022, 6:35 PM

Dec 25 2022

asomers committed rGe35cfc606a29: Add test cases for ping with IP options in the response (authored by asomers).
Add test cases for ping with IP options in the response
Dec 25 2022, 10:04 PM
asomers closed D37210: Add test cases for ping with IP options in the response.
Dec 25 2022, 10:03 PM
asomers added a comment to D37210: Add test cases for ping with IP options in the response.

I can't reproduce markj's problem about dbind, whether I run on a system with or without X . I'm going to guess that it's something about his particular environment. I'll fix the braces and commit.

Dec 25 2022, 9:59 PM
asomers retitled D37740: wg(4): switch to the new if_clone interface from wg: allow creating wireguard interfaces in vnet jails to wg(4): switch to the new if_clone interface.
Dec 25 2022, 6:30 PM
asomers updated the diff for D37740: wg(4): switch to the new if_clone interface.
  • Also replace if_clone_detach with ifc_detach_cloner
Dec 25 2022, 6:29 PM
asomers requested review of D37873: ifconfig: abort if loading a module fails other than for ENOENT.
Dec 25 2022, 6:09 PM
asomers added a comment to D37740: wg(4): switch to the new if_clone interface.

@jhb @kevans you're right, this change isn't necessary to do what I said. I think I got confused by two other problems:

Is there any value to this change anyway, as an act of maintenance? Or should I just abandon it?

Dec 25 2022, 5:46 PM

Dec 20 2022

asomers added inline comments to D37740: wg(4): switch to the new if_clone interface.
Dec 20 2022, 6:21 PM

Dec 19 2022

asomers added a comment to D37752: Document the need to define WITH_CASPER when using casper services.

I see. Can you suggest better wording, or should I just abandon it and assume that users will figure it out?

Dec 19 2022, 11:49 PM
asomers requested review of D37752: Document the need to define WITH_CASPER when using casper services.
Dec 19 2022, 11:31 PM

Dec 18 2022

asomers requested review of D37740: wg(4): switch to the new if_clone interface.
Dec 18 2022, 8:14 PM

Dec 9 2022

asomers added a comment to D37210: Add test cases for ping with IP options in the response.

@markj @jlduran_gmail.com I fixed the network errors that markj found. A necessary side effect seems to be the pep-8 style warnings, and I don't see any way to suppress those. Are there any other problems here?

Dec 9 2022, 5:10 PM
asomers added a comment to D37655: net-mgmt/nfs-exporter: update to 0.3.2.

Thanks for the review. As you probably figured out, it needs llvm90 regardless of the system compiler, because it needs libclang.

Dec 9 2022, 2:01 PM
asomers committed R11:56eb6d1dae8f: net-mgmt/nfs-exporter: update to 0.3.2 (authored by asomers).
net-mgmt/nfs-exporter: update to 0.3.2
Dec 9 2022, 2:01 PM
asomers closed D37655: net-mgmt/nfs-exporter: update to 0.3.2.
Dec 9 2022, 2:01 PM
asomers requested review of D37655: net-mgmt/nfs-exporter: update to 0.3.2.
Dec 9 2022, 2:44 AM

Dec 8 2022

asomers committed rG6c93a2d0bc37: [skip ci] improvements to cap_sysctl.3 (authored by asomers).
[skip ci] improvements to cap_sysctl.3
Dec 8 2022, 7:46 PM
asomers closed D37586: [skip ci] improvements to cap_sysctl.3.
Dec 8 2022, 7:46 PM

Dec 2 2022

asomers committed rGd2ce00e9a617: Allow any user to read the NFS stats, for example with nfsstat(1). (authored by asomers).
Allow any user to read the NFS stats, for example with nfsstat(1).
Dec 2 2022, 5:22 AM
asomers added a comment to D37589: Allow any user to read the NFS stats, for example with nfsstat(1)..

Ok, I committed it. Next I'll fix sysutils/nfs_exporter to run as non-root too.

Dec 2 2022, 5:22 AM
asomers closed D37589: Allow any user to read the NFS stats, for example with nfsstat(1)..
Dec 2 2022, 5:21 AM

Dec 1 2022

asomers requested review of D37589: Allow any user to read the NFS stats, for example with nfsstat(1)..
Dec 1 2022, 9:10 PM
asomers requested review of D37586: [skip ci] improvements to cap_sysctl.3.
Dec 1 2022, 4:51 PM

Nov 30 2022

asomers committed rG34120c0c5234: [skip ci] document first appearance of fhlink et al (authored by asomers).
[skip ci] document first appearance of fhlink et al
Nov 30 2022, 9:58 PM
asomers closed D37575: [skip ci] document first appearance of fhlink et al.
Nov 30 2022, 9:58 PM
asomers requested review of D37575: [skip ci] document first appearance of fhlink et al.
Nov 30 2022, 5:26 PM
asomers added inline comments to D37210: Add test cases for ping with IP options in the response.
Nov 30 2022, 4:35 PM
asomers added inline comments to D37210: Add test cases for ping with IP options in the response.
Nov 30 2022, 4:25 PM
asomers updated the diff for D37210: Add test cases for ping with IP options in the response.
  • Add missing file
  • Match ping's stdout in the injection tests.
  • Python style
  • More specific output checking for inject_pip
  • fixup:
Nov 30 2022, 4:24 PM
asomers added a comment to D37210: Add test cases for ping with IP options in the response.

One problem I noticed is that the tests can spuriously fail with some error messages from scapy:

markj@nuc> sudo kyua debug ping_test:inject_opts
Executing command [ python3 /usr/tests/sbin/ping/injection.py opts ]
Fail: stderr not empty
--- /dev/null   2022-11-30 14:43:29.782039000 +0000
+++ /tmp/kyua.FOws6H/2/work/check.VgUqKM/stderr 2022-11-30 14:43:27.574257000 +0000
@@ -0,0 +1,5 @@
+
+(injection.py:37468): dbind-WARNING **: 14:43:27.258: Couldn't connect to accessibility bus: Failed to connect to socket /tmp/kyua.y0IpE0/7/work/.cache/at-spi/bus_0: No such file or directory
+WARNING: No IPv4 address found on bridge0 !
+WARNING: No IPv4 address found on epair0a !
+WARNING: more No IPv4 address found on epair0b !
Files left in work directory after failure: .cache, .config, tun.txt
ping_test:inject_opts  ->  failed: atf-check failed; see the output of the test for details
Nov 30 2022, 3:32 PM
asomers added a comment to D37210: Add test cases for ping with IP options in the response.

@thj the fix is in main now. Could you please review again?

Nov 30 2022, 2:01 AM
asomers changed the visibility for D37210: Add test cases for ping with IP options in the response.
Nov 30 2022, 2:00 AM
asomers added a comment to D37519: modify the nfsd so that it can be run in a vnet prison.
  • The sysctl falls out of the krpc code. I don't know why dfr@ provided it. Maybe for old NFS code or some other protocol that uses the krpc. --> If you set it after starting the nfsd, it would override the command line setting, I think. Basically the sysctls are useless for the new nfsd code, but to get rid of them, the krpc would need to be changed to never generate them.
Nov 30 2022, 12:01 AM

Nov 29 2022

asomers added a comment to D37519: modify the nfsd so that it can be run in a vnet prison.

I don't know much about the NFS server code, but I've got a few questions:

Nov 29 2022, 8:45 PM

Nov 23 2022

asomers committed rG0e86854450b4: Don't panic when tasting a disk with sectorsize=0 (authored by asomers).
Don't panic when tasting a disk with sectorsize=0
Nov 23 2022, 9:04 PM
asomers committed rG896282a37f5a: ctld: if adding a target fails, retry it on the next reload (authored by asomers).
ctld: if adding a target fails, retry it on the next reload
Nov 23 2022, 8:57 PM
asomers committed rG4a0c5d391f8a: fusefs: fix VOP_ADVLOCK with SEEK_END (authored by asomers).
fusefs: fix VOP_ADVLOCK with SEEK_END
Nov 23 2022, 8:55 PM

Nov 20 2022

asomers added a comment to D37210: Add test cases for ping with IP options in the response.

@jlduran_gmail.com don't get too invested; @thj already has a fix prepared.

Nov 20 2022, 9:45 PM
asomers added a comment to D37195: Remote stack corruption in ping (Embargoed).

@thj are we ready to commit?

Nov 20 2022, 9:44 PM

Nov 11 2022

asomers accepted D37257: zfs tests: stop writing to arbitrary devices.

Well, it isn't ideal. But it's certainly much better than it used to be, and the ZFS tests are much too big to shoot for "ideal".

Nov 11 2022, 5:35 PM

Nov 9 2022

asomers closed D37313: Don't panic when tasting a disk with sectorsize=0.
Nov 9 2022, 5:23 PM
asomers committed rG05d0f4308caa: Don't panic when tasting a disk with sectorsize=0 (authored by asomers).
Don't panic when tasting a disk with sectorsize=0
Nov 9 2022, 5:23 PM
asomers updated the diff for D37313: Don't panic when tasting a disk with sectorsize=0.
  • Perform the check earlier
Nov 9 2022, 4:55 PM
asomers added a comment to D37313: Don't panic when tasting a disk with sectorsize=0.

Seems ok, but why not handle it in g_label_taste(), or even at some higher level in GEOM (maybe g_disk_create())? I can't think of any classes that will do something sane with a provider with sectorsize 0...

Nov 9 2022, 4:36 PM
asomers requested review of D37313: Don't panic when tasting a disk with sectorsize=0.
Nov 9 2022, 3:22 AM

Nov 8 2022

asomers added a comment to D37309: gmultipath: new command "gmultipath which".
In D37309#847728, @mav wrote:

Not that I have specific objections against this, but I think it would be much better to implement a generic way to print all consumers connected to specified GEOM provider. This code does not look anyhow specific to gmultipath.

Nov 8 2022, 10:14 PM
asomers added inline comments to D37195: Remote stack corruption in ping (Embargoed).
Nov 8 2022, 4:47 PM

Nov 3 2022

asomers added inline comments to D37257: zfs tests: stop writing to arbitrary devices.
Nov 3 2022, 8:36 PM