Page MenuHomeFreeBSD
Feed Advanced Search

Today

asomers added a comment to D21589: arp.c: use getaddrinfo(3) instead of gethostbyname(3).

@hrs do you realize that the submitter is not a committer? Can you commit this change for him?

Tue, Oct 15, 12:12 AM

Fri, Oct 11

asomers committed rS353439: MFZol: Fix performance of "zfs recv" with many deletions.
MFZol: Fix performance of "zfs recv" with many deletions
Fri, Oct 11, 2:59 PM
asomers closed D21895: MFZol: Fix performance of "zfs recv" with many deletions.
Fri, Oct 11, 2:59 PM
asomers added a comment to D21895: MFZol: Fix performance of "zfs recv" with many deletions.

Thanks Allan!

Fri, Oct 11, 2:56 PM

Thu, Oct 10

asomers committed rS353379: zfs: multiple improvements to the zpool_add tests.
zfs: multiple improvements to the zpool_add tests
Thu, Oct 10, 2:18 AM

Wed, Oct 9

asomers committed rS353366: ZFS: fix the zpool_add_010_pos test.
ZFS: fix the zpool_add_010_pos test
Wed, Oct 9, 8:16 PM
asomers committed rS353361: ZFS: in the tests, don't override PWD.
ZFS: in the tests, don't override PWD
Wed, Oct 9, 5:37 PM
asomers committed rS353360: ZFS: multiple fixes to the zpool_import tests.
ZFS: multiple fixes to the zpool_import tests
Wed, Oct 9, 5:24 PM

Tue, Oct 8

asomers committed rS353310: zfs: fix the zfsd_hotspare_007_pos test.
zfs: fix the zfsd_hotspare_007_pos test
Tue, Oct 8, 3:48 PM
asomers committed rS353309: zfs: fix the zfsd_autoreplace_003_pos test.
zfs: fix the zfsd_autoreplace_003_pos test
Tue, Oct 8, 3:33 PM

Mon, Oct 7

asomers committed rS353289: ZFS: fix the redundancy tests.
ZFS: fix the redundancy tests
Mon, Oct 7, 8:21 PM
asomers closed D21901: ZFS: fix the redundancy tests.
Mon, Oct 7, 8:21 PM
asomers committed rS353288: ZFS: mark hotspare_scrub_002_pos as an expected failure.
ZFS: mark hotspare_scrub_002_pos as an expected failure
Mon, Oct 7, 8:19 PM
asomers closed D21898: ZFS: fix the delegate tests.
Mon, Oct 7, 8:14 PM
asomers committed rS353287: ZFS: fix the delegate tests.
ZFS: fix the delegate tests
Mon, Oct 7, 8:14 PM
asomers closed D21878: zfs tests: skip the zfsd tests if zfsd is not already running.
Mon, Oct 7, 7:50 PM
asomers committed rS353286: zfs: skip the zfsd tests if zfsd is not running.
zfs: skip the zfsd tests if zfsd is not running
Mon, Oct 7, 7:50 PM
asomers committed rS353285: zfs: fix the zdb_001_neg test.
zfs: fix the zdb_001_neg test
Mon, Oct 7, 7:48 PM
asomers committed rS353284: ZFS: fix the zpool_get_002_pos test.
ZFS: fix the zpool_get_002_pos test
Mon, Oct 7, 7:24 PM
asomers committed rS353282: zfs: fix the slog_012_neg test.
zfs: fix the slog_012_neg test
Mon, Oct 7, 6:56 PM
asomers committed rS353281: ZFS: fix several zvol_misc tests.
ZFS: fix several zvol_misc tests
Mon, Oct 7, 6:21 PM

Sat, Oct 5

asomers added inline comments to D21900: Fix problems in the kern_maxfiles__increase test.
Sat, Oct 5, 10:56 PM
asomers committed rS353118: ZFS: fix several of the "zpool create" tests.
ZFS: fix several of the "zpool create" tests
Sat, Oct 5, 3:20 AM
asomers committed rS353117: ZFS: the hotspare_add_004_neg test needs at least two disks.
ZFS: the hotspare_add_004_neg test needs at least two disks
Sat, Oct 5, 1:35 AM

Fri, Oct 4

asomers created D21901: ZFS: fix the redundancy tests.
Fri, Oct 4, 10:28 PM
asomers updated subscribers of D21900: Fix problems in the kern_maxfiles__increase test.

That's not much of a test plan. Perhaps try sudo?

Fri, Oct 4, 9:57 PM
asomers created D21898: ZFS: fix the delegate tests.
Fri, Oct 4, 5:58 PM
asomers updated the diff for D21895: MFZol: Fix performance of "zfs recv" with many deletions.

Update tunable description, too.

Fri, Oct 4, 4:55 PM
asomers created D21895: MFZol: Fix performance of "zfs recv" with many deletions.
Fri, Oct 4, 3:20 PM

Thu, Oct 3

asomers updated subscribers of D21878: zfs tests: skip the zfsd tests if zfsd is not already running.

cc @pinchuk.alek_gmail.com

Thu, Oct 3, 8:23 PM
asomers added a comment to D21164: libefivar: remove bogus WARNS assignment.

ping @imp does this look correct to you?

Thu, Oct 3, 8:22 PM
asomers committed rS353068: tftp: fix two minor Coverity CIDs.
tftp: fix two minor Coverity CIDs
Thu, Oct 3, 8:22 PM
asomers closed D21695: tftp: fix two minor Coverity CIDs.
Thu, Oct 3, 8:22 PM

Wed, Oct 2

asomers created D21878: zfs tests: skip the zfsd tests if zfsd is not already running.
Wed, Oct 2, 2:41 PM
asomers added a comment to D21876: simplify path handling in sysctl_try_reclaim_vnode.

If PATH_MAX + 1 is a problem here, then it's also a problem at fs/nfsserver/nfs_nfsdport.c:{3520, 3527, 3534, 3542}.

Wed, Oct 2, 1:47 PM
asomers added inline comments to D20519: Add a debugging facility to manually reclaim a vnode.
Wed, Oct 2, 1:08 PM

Sun, Sep 22

asomers committed rS352588: MF stable/12 r352489.
MF stable/12 r352489
Sun, Sep 22, 12:13 AM

Sat, Sep 21

asomers committed rS352573: MF stable/12 r352534:.
MF stable/12 r352534:
Sat, Sep 21, 1:00 PM

Thu, Sep 19

asomers committed rS352534: MFC r352417:.
MFC r352417:
Thu, Sep 19, 5:42 PM

Wed, Sep 18

asomers committed rS352490: MFC r351192, r351203.
MFC r351192, r351203
Wed, Sep 18, 5:21 PM
asomers committed rS352489: MFC r351192, r351203.
MFC r351192, r351203
Wed, Sep 18, 5:18 PM

Tue, Sep 17

asomers created D21695: tftp: fix two minor Coverity CIDs.
Tue, Sep 17, 11:18 PM
asomers added a comment to D21638: Add kqueue support for ZFS..

My experience is not directly applicable. All I did was add kqueue support for /dev/fuse, not for files stored on fusefs, and I was only concerned with EVFILT_(READ|WRITE), not EVFILT_VNODE. I would suggest that before you continue working on this patch, you write a test case.

Tue, Sep 17, 3:43 AM

Mon, Sep 16

asomers committed rS352417: Fix an off-by-one error from r351961.
Fix an off-by-one error from r351961
Mon, Sep 16, 4:41 PM
asomers committed rS352414: fusefs: initialize C++ classes the Coverity way.
fusefs: initialize C++ classes the Coverity way
Mon, Sep 16, 3:56 PM
asomers committed rS352413: fusefs: fix some minor Coverity CIDs in the tests.
fusefs: fix some minor Coverity CIDs in the tests
Mon, Sep 16, 3:45 PM
asomers committed rS352404: fusefs: fix some minor issues with fuse_vnode_setparent.
fusefs: fix some minor issues with fuse_vnode_setparent
Mon, Sep 16, 2:52 PM
asomers closed D21630: fusefs: fix some minor issues with fuse_vnode_setparent.
Mon, Sep 16, 2:52 PM
asomers committed rS352372: MFC r352231:.
MFC r352231:
Mon, Sep 16, 12:59 AM
asomers committed rS352371: MFC r351318, r351330, r351393, r351398, r351440, r351461, r351548, r352226….
MFC r351318, r351330, r351393, r351398, r351440, r351461, r351548, r352226…
Mon, Sep 16, 12:57 AM

Sun, Sep 15

asomers committed rS352357: MFC r350994, r350998, r351030, r351033, r351171, r351223, r351226, r351424.
MFC r350994, r350998, r351030, r351033, r351171, r351223, r351226, r351424
Sun, Sep 15, 4:53 PM

Sep 15 2019

asomers committed rP512089: sysutils/fusefs-libs: don't install irrelevant man pages.
sysutils/fusefs-libs: don't install irrelevant man pages
Sep 15 2019, 4:46 AM
asomers committed rS352351: MFC the new fusefs driver.
MFC the new fusefs driver
Sep 15 2019, 4:15 AM

Sep 13 2019

asomers created D21630: fusefs: fix some minor issues with fuse_vnode_setparent.
Sep 13 2019, 1:54 AM

Sep 12 2019

asomers committed rS352254: Record mergeinfo for r352232.
Record mergeinfo for r352232
Sep 12 2019, 4:28 PM
asomers committed rS352252: MFC r351172:.
MFC r351172:
Sep 12 2019, 4:23 PM

Sep 11 2019

asomers committed rS352232: MFC r350993, r350997, r351079-r351080, r351082, r351090, r351101-r351102.
MFC r350993, r350997, r351079-r351080, r351082, r351090, r351101-r351102
Sep 11 2019, 8:13 PM
asomers committed rS352231: getsockopt.2: clarify that SO_TIMESTAMP is not 100% reliable.
getsockopt.2: clarify that SO_TIMESTAMP is not 100% reliable
Sep 11 2019, 7:48 PM
asomers closed D21607: getsockopt.2: clarify that SO_TIMESTAMP is not 100% reliable.
Sep 11 2019, 7:48 PM
asomers updated the diff for D21607: getsockopt.2: clarify that SO_TIMESTAMP is not 100% reliable.

Fix typo

Sep 11 2019, 7:37 PM
asomers committed rS352230: fusefs: Fix iosize for FUSE_WRITE in 7.8 compat mode.
fusefs: Fix iosize for FUSE_WRITE in 7.8 compat mode
Sep 11 2019, 7:29 PM
asomers closed D21557: fusefs: Fix iosize for FUSE_WRITE in 7.8 compat mode.
Sep 11 2019, 7:29 PM
asomers updated the diff for D21607: getsockopt.2: clarify that SO_TIMESTAMP is not 100% reliable.

Explicitly state that a timestamp may not be returned

Sep 11 2019, 7:26 PM
asomers created D21607: getsockopt.2: clarify that SO_TIMESTAMP is not 100% reliable.
Sep 11 2019, 6:59 PM
asomers committed rS352229: ping: Verify whether a datagram timestamp was actually received..
ping: Verify whether a datagram timestamp was actually received.
Sep 11 2019, 6:55 PM
asomers committed rS352226: ping: fix a string in an error message.
ping: fix a string in an error message
Sep 11 2019, 6:08 PM

Sep 9 2019

asomers committed rP511693: security/py-certbot: Add periodic script for renewing certificates.
security/py-certbot: Add periodic script for renewing certificates
Sep 9 2019, 7:51 PM

Sep 7 2019

asomers committed rS352025: mount_fusefs: fix a segfault on memory allocation failure.
mount_fusefs: fix a segfault on memory allocation failure
Sep 7 2019, 9:49 PM
asomers added a comment to D21434: ping6: separate command line tokens parsing from processing of the option arguments.

Aha, to me it's similar to C++ templates. So there would be only one getopt loop at a source level, and two getopt loops at an object level. The two getopt loops (for the ping6's new option set and for the old one) would be called from a single source file like this:

if (strcmp(argv[0], "ping6") == 0)
    parse_old_options();
else
    parse_new_options();

so the name of the parse function would also need to be parametrized to avoid conflicts of symbols at the object level.

Sep 7 2019, 7:27 PM
asomers committed rS352021: fusefs: suppress some Coverity resource leak CIDs in the tests.
fusefs: suppress some Coverity resource leak CIDs in the tests
Sep 7 2019, 7:26 PM

Sep 6 2019

asomers created D21557: fusefs: Fix iosize for FUSE_WRITE in 7.8 compat mode.
Sep 6 2019, 10:39 PM
asomers committed rS351964: MFC r350858-r350859, r350987, r351170.
MFC r350858-r350859, r350987, r351170
Sep 6 2019, 8:16 PM
asomers added a comment to D21434: ping6: separate command line tokens parsing from processing of the option arguments.

The single getopt loop would have to be parametrized at runtime. How do the preprocessor directives fit into this?

Sep 6 2019, 8:08 PM
asomers committed rS351963: fusefs: coverity cleanup in the tests.
fusefs: coverity cleanup in the tests
Sep 6 2019, 7:50 PM
asomers closed D21457: fusefs: coverity cleanup in the tests.
Sep 6 2019, 7:50 PM
asomers added inline comments to D21457: fusefs: coverity cleanup in the tests.
Sep 6 2019, 7:47 PM
asomers committed rS351962: MFC r350556:.
MFC r350556:
Sep 6 2019, 7:46 PM
asomers committed rS351961: Coverity fixes in fusefs(5).
Coverity fixes in fusefs(5)
Sep 6 2019, 7:40 PM
asomers closed D21466: Coverity fixes in fusefs(5).
Sep 6 2019, 7:40 PM
asomers committed rS351960: MFC r350453:.
MFC r350453:
Sep 6 2019, 7:37 PM
asomers committed rS351958: MFC r350426:.
MFC r350426:
Sep 6 2019, 7:29 PM
asomers committed rS351957: MFC r350386, r350390.
MFC r350386, r350390
Sep 6 2019, 7:22 PM
asomers committed rS351955: MFC r350314:.
MFC r350314:
Sep 6 2019, 7:07 PM
asomers committed rS351949: MFC r350291:.
MFC r350291:
Sep 6 2019, 6:23 PM
asomers committed rS351948: MFC r350268:.
MFC r350268:
Sep 6 2019, 6:14 PM
asomers committed rS351947: MFC r350227:.
MFC r350227:
Sep 6 2019, 6:11 PM
asomers committed rS351946: MFC r346186:.
MFC r346186:
Sep 6 2019, 6:10 PM
asomers committed rS351945: MFC r345986:.
MFC r345986:
Sep 6 2019, 6:08 PM
asomers committed rS351944: MFC r345675, r345689.
MFC r345675, r345689
Sep 6 2019, 6:03 PM
asomers committed rS351943: MFC r344183-r344187, r344333-r344334, r344407, r344857, r344865 (by cem).
MFC r344183-r344187, r344333-r344334, r344407, r344857, r344865 (by cem)
Sep 6 2019, 5:56 PM
asomers committed rS351941: MFC r350225:.
MFC r350225:
Sep 6 2019, 5:43 PM
asomers committed rS351940: MFC r345350, r346441, r346765.
MFC r345350, r346441, r346765
Sep 6 2019, 5:21 PM

Sep 4 2019

asomers added a comment to D21434: ping6: separate command line tokens parsing from processing of the option arguments.

Does it mean that there could be only one getopt loop with a variable getopt string for solving the compatibility problem?

Yes, exactly.

In this case there would have to be some syntactic check duplication in the getopt's switch-case. Some options were renamed according to the pattern (A ->B, B->C) so one case would contain syntactic check for option A and the other for both B and A. If only the case labels could have been non-constant.

Sep 4 2019, 8:01 PM
asomers added a comment to D21434: ping6: separate command line tokens parsing from processing of the option arguments.

I need to be sure I understand you correctly.

Since only a few options have changed, what about defining constants like #DEFINE ADDRTYPE_OPT 'k' before including options.h, and composing the getopt string like we already do with ADDOPTS.

Does it mean that there could be only one getopt loop with a variable getopt string for solving the compatibility problem?

Sep 4 2019, 3:01 PM

Sep 3 2019

asomers updated the diff for D21457: fusefs: coverity cleanup in the tests.

Add one more change that I forgot to save before starting the review

Sep 3 2019, 10:30 PM
asomers added a comment to D21434: ping6: separate command line tokens parsing from processing of the option arguments.

Since only a few options have changed, what about defining constants like #DEFINE ADDRTYPE_OPT 'k' before including options.h, and composing the getopt string like we already do with ADDOPTS. Then in options.c, for those options whose flags differ between the two programs, compose the error message at runtime.

Sep 3 2019, 8:41 PM
asomers added a comment to D21434: ping6: separate command line tokens parsing from processing of the option arguments.

So what's the plan for ping -6 vs ping? Are you going to have two different copies of options_parse?

Sep 3 2019, 6:46 PM
asomers added inline comments to D21434: ping6: separate command line tokens parsing from processing of the option arguments.
Sep 3 2019, 3:22 PM

Sep 1 2019

asomers added a comment to D21434: ping6: separate command line tokens parsing from processing of the option arguments.

Yes, that's about what I had in mind. But did you intend to set f_sock_buff_size in the getopt loop?

Sep 1 2019, 2:06 AM

Aug 31 2019

asomers added inline comments to D21434: ping6: separate command line tokens parsing from processing of the option arguments.
Aug 31 2019, 4:29 AM