sockstat: improve handling of path state
Needs ReviewPublic
Actions

Authored by tuexen on Thu, Oct 9, 9:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 10, 4:30 PM

	Unknown Object (File)
	Fri, Oct 10, 4:30 PM

	Unknown Object (File)
	Fri, Oct 10, 10:47 AM

	Unknown Object (File)
	Fri, Oct 10, 1:34 AM

	Unknown Object (File)
	Fri, Oct 10, 1:32 AM

	Unknown Object (File)
	Thu, Oct 9, 11:06 PM

	Unknown Object (File)
	Thu, Oct 9, 11:02 PM

	Unknown Object (File)
	Thu, Oct 9, 10:37 PM

Subscribers

imp

ziaee

Details

Reviewers

asomers

Summary

Only suppress the path state column when producing traditional text output. When generating html output, always include the column. When generating json or xml output, only include the path state, if it is applicable.
This should address the issues raised by Alan.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tuexen created this revision.Thu, Oct 9, 9:31 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptThu, Oct 9, 9:31 PM

tuexen requested review of this revision.Thu, Oct 9, 9:31 PM

ziaee added inline comments.Thu, Oct 9, 10:52 PM

usr.bin/sockstat/sockstat.1
208	This seems to conflict with what your commit message says. When using text, json, or xml, it is shown if applicable, but if using html, it is shown even if empty?