Page MenuHomeFreeBSD

fusefs: fix intermittency in the BadServer.ShortWrite test
ClosedPublic

Authored by asomers on Tue, Oct 14, 2:22 AM.
Tags
None
Referenced Files
F133071704: D53080.diff
Wed, Oct 22, 5:22 PM
Unknown Object (File)
Wed, Oct 22, 5:18 AM
Unknown Object (File)
Sun, Oct 19, 4:50 AM
Unknown Object (File)
Sat, Oct 18, 4:26 AM
Unknown Object (File)
Fri, Oct 17, 3:37 PM
Unknown Object (File)
Fri, Oct 17, 3:37 PM
Unknown Object (File)
Fri, Oct 17, 3:37 PM
Unknown Object (File)
Fri, Oct 17, 6:56 AM
Subscribers

Details

Summary

This test implicitly depended on the order in which two threads
completed. If the test thread finished first, the test would pass. But
if the mock file system thread did, it would attempt to read from an
unmounted file system, and fail. As a result, the test would randomly
fail once out of every several thousand executions. Fix it by telling
the mock file system's event loop to exit without attempting to read any
more events.

Reported by: Siva Mahadevan <me@svmhdvn.name>
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

LGTM and makes sense. Tested on loop for 15+ minutes and found no failures.

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Oct 14, 2:47 PM
This revision was automatically updated to reflect the committed changes.