Page MenuHomeFreeBSD
Differential D51316

fusefs: add a regression test for a cluster_read bug
ClosedPublic
Actions

Authored by asomers on Jul 14 2025, 11:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 24, 8:59 PM
Unknown Object (File)
Mon, Oct 13, 8:12 AM
Unknown Object (File)
Mon, Oct 13, 8:12 AM
Unknown Object (File)
Sun, Oct 12, 7:57 PM
Unknown Object (File)
Fri, Sep 26, 11:32 PM
Unknown Object (File)
Sep 21 2025, 8:35 AM
Unknown Object (File)
Sep 15 2025, 2:17 PM
Unknown Object (File)
Sep 13 2025, 7:11 AM
View All 22 Files
Subscribers
danfe
imp
markj

Details

Reviewers
arrowd
Commits
rG6d408ac49073: fusefs: add a regression test for a cluster_read bug
Summary

If VOP_BMAP returns an error during readahead, cluster_read will fail
the read, even though the actually requested data was read just fine.

This commit includes the regression test only. The solution is under
review at https://reviews.freebsd.org/D51254 .

PR: 264196
Reported by: danfe

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers created this revision.Jul 14 2025, 11:34 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 14 2025, 11:34 PM
asomers requested review of this revision.Jul 14 2025, 11:34 PM
Harbormaster completed remote builds in B65435: Diff 158506.Jul 14 2025, 11:34 PM
asomers mentioned this in D51254: vfs_cluster.c: Do not propagate VOP_BMAP errors to the caller.Jul 14 2025, 11:35 PM
arrowd added a comment.Jul 15 2025, 5:43 AM

Would you like me to check if the test really fails on an unpatched system?

tests/sys/fs/fusefs/bmap.cc
264

How about checking 4 identical reads? Just in case the failure having a pattern "OK FAIL OK FAIL".

asomers added a comment.Jul 15 2025, 2:19 PM
In D51316#1172010, @arrowd wrote:

Would you like me to check if the test really fails on an unpatched system?

I already have, and it really does fail.

asomers added a comment.Thu, Oct 23, 12:50 PM

@arrowd now that you've committed the main bmap patch, are you ok with this test?

arrowd accepted this revision.Thu, Oct 23, 1:34 PM

I had to learn a bit about gmock to properly review this. LGTM, FWIW.

This revision is now accepted and ready to land.Thu, Oct 23, 1:34 PM
asomers added a comment.Thu, Oct 23, 1:40 PM

Thanks for getting this fixed, @arrowd .

Closed by commit rG6d408ac49073: fusefs: add a regression test for a cluster_read bug (authored by asomers). · Explain WhyThu, Oct 23, 1:41 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rG6d408ac49073: fusefs: add a regression test for a cluster_read bug.

Revision Contents
Changeset List

PathSize
tests/
sys/
fs/
fusefs/
87 lines

Diff 164882

View Options

tests/sys/fs/fusefs/bmap.cc

Loading...