fusefs: add a regression test for a cluster_read bug
Needs ReviewPublic
Actions

Authored by asomers on Jul 14 2025, 11:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 13, 8:12 AM

	Unknown Object (File)
	Mon, Oct 13, 8:12 AM

	Unknown Object (File)
	Sun, Oct 12, 7:57 PM

	Unknown Object (File)
	Fri, Sep 26, 11:32 PM

	Unknown Object (File)
	Sep 21 2025, 8:35 AM

	Unknown Object (File)
	Sep 15 2025, 2:17 PM

	Unknown Object (File)
	Sep 13 2025, 7:11 AM

	Unknown Object (File)
	Sep 12 2025, 12:17 PM

Subscribers

Details

Reviewers

arrowd

Summary

If VOP_BMAP returns an error during readahead, cluster_read will fail
the read, even though the actually requested data was read just fine.

This commit includes the regression test only. The solution is under
review at https://reviews.freebsd.org/D51254 .

PR: 264196
Reported by: danfe

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 65435
Build 62318: arc lint + arc unit

Event Timeline

asomers created this revision.Jul 14 2025, 11:34 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 14 2025, 11:34 PM

asomers requested review of this revision.Jul 14 2025, 11:34 PM

Harbormaster completed remote builds in B65435: Diff 158506.Jul 14 2025, 11:34 PM

asomers mentioned this in D51254: vfs_cluster.c: Do not propagate VOP_BMAP errors to the caller.Jul 14 2025, 11:35 PM

Would you like me to check if the test really fails on an unpatched system?

tests/sys/fs/fusefs/bmap.cc
264	How about checking 4 identical reads? Just in case the failure having a pattern "OK FAIL OK FAIL".

In D51316#1172010, @arrowd wrote:

Would you like me to check if the test really fails on an unpatched system?

I already have, and it really does fail.

Revision Contents
Changeset List

Path

Size

tests/

sys/

fs/

fusefs/

bmap.cc

87 lines

Diff 158506

View Options

tests/sys/fs/fusefs/bmap.cc

fusefs: add a regression test for a cluster_read bugNeeds ReviewPublicActions