Page MenuHomeFreeBSD

fusefs: add a regression test for a cluster_read bug
ClosedPublic

Authored by asomers on Jul 14 2025, 11:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 24, 8:59 PM
Unknown Object (File)
Mon, Oct 13, 8:12 AM
Unknown Object (File)
Mon, Oct 13, 8:12 AM
Unknown Object (File)
Sun, Oct 12, 7:57 PM
Unknown Object (File)
Fri, Sep 26, 11:32 PM
Unknown Object (File)
Sep 21 2025, 8:35 AM
Unknown Object (File)
Sep 15 2025, 2:17 PM
Unknown Object (File)
Sep 13 2025, 7:11 AM
Subscribers

Details

Summary

If VOP_BMAP returns an error during readahead, cluster_read will fail
the read, even though the actually requested data was read just fine.

This commit includes the regression test only. The solution is under
review at https://reviews.freebsd.org/D51254 .

PR: 264196
Reported by: danfe

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Would you like me to check if the test really fails on an unpatched system?

tests/sys/fs/fusefs/bmap.cc
264

How about checking 4 identical reads? Just in case the failure having a pattern "OK FAIL OK FAIL".

Would you like me to check if the test really fails on an unpatched system?

I already have, and it really does fail.

@arrowd now that you've committed the main bmap patch, are you ok with this test?

I had to learn a bit about gmock to properly review this. LGTM, FWIW.

This revision is now accepted and ready to land.Thu, Oct 23, 1:34 PM