Page MenuHomeFreeBSD

fusefs: Fix intermittency in the BadServer.ShortWrite test case
ClosedPublic

Authored by asomers on Oct 26 2025, 12:48 AM.
Tags
None
Referenced Files
F137919361: D53357.id165039.diff
Thu, Nov 27, 6:04 AM
Unknown Object (File)
Wed, Nov 26, 12:26 AM
Unknown Object (File)
Mon, Nov 24, 11:51 AM
Unknown Object (File)
Fri, Nov 7, 8:25 PM
Unknown Object (File)
Oct 28 2025, 1:34 PM
Unknown Object (File)
Oct 27 2025, 6:24 PM
Unknown Object (File)
Oct 26 2025, 8:02 PM
Unknown Object (File)
Oct 26 2025, 8:02 PM
Subscribers

Details

Summary

We were using the m_quit bit for two similar but distinct uses:

  • To instruct the server to quit
  • To cope with the kernel forcibly unmounting the fs

Fix the intermittent test failure by adding a separate bit,
m_expect_unmount, to handle cases like the latter.

Reported by: Siva Mahadevan <me@svmhdvn.name>
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Seems to fix the intermittency even with a very long runtime. I'm not the best person to review the changes, but it works well for me.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 27 2025, 7:12 PM
This revision was automatically updated to reflect the committed changes.