sockstat: show path state column only when useful
ClosedPublic
Actions

Authored by tuexen on Wed, Oct 8, 7:54 PM.

Details

Reviewers

asomers
glebius
rscheff
cc
rrs
peter.lei_ieee.org
lstewart

Commits

rG746eadecaa7d: sockstat: show path state column only when useful

Summary

Showing the path state column is only useful, if there is at least one SCTP endpoint shown, which is not in the state CLOSED or LISTEN. Don't show it when it is not useful.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Wed, Oct 8, 7:54 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptWed, Oct 8, 7:54 PM

tuexen requested review of this revision.Wed, Oct 8, 7:54 PM

Could you give an example of what the output looks like before and after?

usr.bin/sockstat/sockstat.1
208

In D52986#1210638, @asomers wrote:

Could you give an example of what the output looks like before and after?

Sure. Here is the output without the change:

tuexen@head:~/freebsd-src/usr.bin/sockstat % sockstat -sPtcp
USER   COMMAND     PID FD PROTO LOCAL ADDRESS         FOREIGN ADDRESS       PATH STATE CONN STATE 
tuexen sshd-sessi 1661  7 tcp4  192.168.1.71:22       192.168.1.195:56451   ??         ESTABLISHED
root   sshd-sessi 1659  7 tcp4  192.168.1.71:22       192.168.1.195:56451   ??         ESTABLISHED
tuexen sshd-sessi 1654  7 tcp4  192.168.1.71:22       192.168.1.195:56448   ??         ESTABLISHED
root   sshd-sessi 1652  7 tcp4  192.168.1.71:22       192.168.1.195:56448   ??         ESTABLISHED
tuexen sshd-sessi 1647  7 tcp4  192.168.1.71:22       192.168.1.195:56445   ??         ESTABLISHED
root   sshd-sessi 1645  7 tcp4  192.168.1.71:22       192.168.1.195:56445   ??         ESTABLISHED
root   sshd       1586  6 tcp6  *:22                  *:*                   ??         LISTEN     
root   sshd       1586  7 tcp4  *:22                  *:*                   ??         LISTEN

Here is the output with the patch applied:

tuexen@head:~/freebsd-src/usr.bin/sockstat % sockstat -sPtcp
USER   COMMAND     PID FD PROTO LOCAL ADDRESS         FOREIGN ADDRESS       CONN STATE 
tuexen sshd-sessi 1661  7 tcp4  192.168.1.71:22       192.168.1.195:56451   ESTABLISHED
root   sshd-sessi 1659  7 tcp4  192.168.1.71:22       192.168.1.195:56451   ESTABLISHED
tuexen sshd-sessi 1654  7 tcp4  192.168.1.71:22       192.168.1.195:56448   ESTABLISHED
root   sshd-sessi 1652  7 tcp4  192.168.1.71:22       192.168.1.195:56448   ESTABLISHED
tuexen sshd-sessi 1647  7 tcp4  192.168.1.71:22       192.168.1.195:56445   ESTABLISHED
root   sshd-sessi 1645  7 tcp4  192.168.1.71:22       192.168.1.195:56445   ESTABLISHED
root   sshd       1586  6 tcp6  *:22                  *:*                   LISTEN     
root   sshd       1586  7 tcp4  *:22                  *:*                   LISTEN

rrs accepted this revision.Thu, Oct 9, 3:01 PM

This revision is now accepted and ready to land.Thu, Oct 9, 3:01 PM

Closed by commit rG746eadecaa7d: sockstat: show path state column only when useful (authored by tuexen). · Explain WhyThu, Oct 9, 7:19 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG746eadecaa7d: sockstat: show path state column only when useful.