Showing the path state column is only useful, if there is at least one SCTP endpoint shown, which is not in the state CLOSED or LISTEN. Don't show it when it is not useful.
Details
Details
- Reviewers
asomers glebius rscheff cc rrs peter.lei_ieee.org lstewart - Commits
- rGf7a7c2026ccb: sockstat: show path state column only when useful
rG46d39e9f09a4: sockstat: show path state column only when useful
rG9a0a114b7f10: sockstat: show path state column only when useful
rG746eadecaa7d: sockstat: show path state column only when useful
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Could you give an example of what the output looks like before and after?
| usr.bin/sockstat/sockstat.1 | ||
|---|---|---|
| 208 | ||
Comment Actions
Sure. Here is the output without the change:
tuexen@head:~/freebsd-src/usr.bin/sockstat % sockstat -sPtcp USER COMMAND PID FD PROTO LOCAL ADDRESS FOREIGN ADDRESS PATH STATE CONN STATE tuexen sshd-sessi 1661 7 tcp4 192.168.1.71:22 192.168.1.195:56451 ?? ESTABLISHED root sshd-sessi 1659 7 tcp4 192.168.1.71:22 192.168.1.195:56451 ?? ESTABLISHED tuexen sshd-sessi 1654 7 tcp4 192.168.1.71:22 192.168.1.195:56448 ?? ESTABLISHED root sshd-sessi 1652 7 tcp4 192.168.1.71:22 192.168.1.195:56448 ?? ESTABLISHED tuexen sshd-sessi 1647 7 tcp4 192.168.1.71:22 192.168.1.195:56445 ?? ESTABLISHED root sshd-sessi 1645 7 tcp4 192.168.1.71:22 192.168.1.195:56445 ?? ESTABLISHED root sshd 1586 6 tcp6 *:22 *:* ?? LISTEN root sshd 1586 7 tcp4 *:22 *:* ?? LISTEN
Here is the output with the patch applied:
tuexen@head:~/freebsd-src/usr.bin/sockstat % sockstat -sPtcp USER COMMAND PID FD PROTO LOCAL ADDRESS FOREIGN ADDRESS CONN STATE tuexen sshd-sessi 1661 7 tcp4 192.168.1.71:22 192.168.1.195:56451 ESTABLISHED root sshd-sessi 1659 7 tcp4 192.168.1.71:22 192.168.1.195:56451 ESTABLISHED tuexen sshd-sessi 1654 7 tcp4 192.168.1.71:22 192.168.1.195:56448 ESTABLISHED root sshd-sessi 1652 7 tcp4 192.168.1.71:22 192.168.1.195:56448 ESTABLISHED tuexen sshd-sessi 1647 7 tcp4 192.168.1.71:22 192.168.1.195:56445 ESTABLISHED root sshd-sessi 1645 7 tcp4 192.168.1.71:22 192.168.1.195:56445 ESTABLISHED root sshd 1586 6 tcp6 *:22 *:* LISTEN root sshd 1586 7 tcp4 *:22 *:* LISTEN