Page MenuHomeFreeBSD
Differential D48594

ctld: Use bool in uclparse.c
ClosedPublic
Actions

Authored by jhb on Jan 22 2025, 7:52 PM.
Tags
None
Referenced Files
F156494623: D48594.id.diff
Thu, May 14, 2:45 AM
F156481571: D48594.id149718.diff
Wed, May 13, 11:40 PM
F156467219: D48594.diff
Wed, May 13, 9:20 PM
F156443375: D48594.id149825.diff
Wed, May 13, 5:46 PM
Unknown Object (File)
Mon, May 11, 12:14 PM
Unknown Object (File)
Mon, May 4, 12:12 AM
Unknown Object (File)
Sat, May 2, 12:39 PM
Unknown Object (File)
Mon, Apr 27, 10:27 PM
View All Files
Subscribers
imp

Details

Reviewers
trasz
asomers
mav
Commits
rGa3311db4010d: ctld: Use bool in uclparse.c
rG78cd9f0c0941: ctld: Use bool in uclparse.c
Summary

Previously these functions all returned either 0 or 1, but 0 was
success and 1 was failure. Use a bool where false indicates failure
instead which is more readable.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Jan 22 2025, 7:52 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 22 2025, 7:52 PM
jhb requested review of this revision.Jan 22 2025, 7:52 PM
jhb added a parent revision: D48593: iscsi: Move valid_iscsi_name to libiscsiutil.
jhb added a child revision: D48595: ctld: Use nvlist instead of home-rolled name-value lists.
Harbormaster completed remote builds in B61887: Diff 149718.Jan 22 2025, 7:53 PM
asomers accepted this revision.Jan 22 2025, 8:04 PM
This revision is now accepted and ready to land.Jan 22 2025, 8:04 PM
mav accepted this revision.Jan 23 2025, 4:26 PM

I guess instead of 1 could be expected some error codes, that just never happened.

jhb updated this revision to Diff 149825.Jan 23 2025, 7:14 PM

Two more that I missed

This revision now requires review to proceed.Jan 23 2025, 7:14 PM
Harbormaster completed remote builds in B61945: Diff 149825.Jan 23 2025, 7:14 PM
asomers accepted this revision.Jan 23 2025, 7:15 PM
This revision is now accepted and ready to land.Jan 23 2025, 7:15 PM
Closed by commit rG78cd9f0c0941: ctld: Use bool in uclparse.c (authored by jhb). · Explain WhyJan 24 2025, 2:55 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG78cd9f0c0941: ctld: Use bool in uclparse.c.
jhb added a commit: rGa3311db4010d: ctld: Use bool in uclparse.c.Jan 27 2026, 6:44 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
ctld/
256 lines

Diff 149883

View Options

usr.sbin/ctld/uclparse.c

Loading...