Page MenuHomeFreeBSD
Differential D48594

ctld: Use bool in uclparse.c
ClosedPublic
Actions

Authored by jhb on Wed, Jan 22, 7:52 PM.
Tags
None
Referenced Files
F109479116: D48594.diff
Wed, Feb 5, 3:13 PM
F109410324: D48594.diff
Tue, Feb 4, 5:16 PM
Unknown Object (File)
Tue, Feb 4, 7:45 AM
Unknown Object (File)
Thu, Jan 30, 8:34 PM
Unknown Object (File)
Wed, Jan 29, 2:52 AM
Unknown Object (File)
Tue, Jan 28, 5:38 PM
Subscribers
imp

Details

Reviewers
trasz
asomers
mav
Commits
rG78cd9f0c0941: ctld: Use bool in uclparse.c
Summary

Previously these functions all returned either 0 or 1, but 0 was
success and 1 was failure. Use a bool where false indicates failure
instead which is more readable.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61945
Build 58829: arc lint + arc unit

Event Timeline

jhb created this revision.Wed, Jan 22, 7:52 PM
Herald added a subscriber: imp. · View Herald TranscriptWed, Jan 22, 7:52 PM
jhb requested review of this revision.Wed, Jan 22, 7:52 PM
jhb added a parent revision: D48593: iscsi: Move valid_iscsi_name to libiscsiutil.
jhb added a child revision: D48595: ctld: Use nvlist instead of home-rolled name-value lists.
Harbormaster completed remote builds in B61887: Diff 149718.Wed, Jan 22, 7:53 PM
asomers accepted this revision.Wed, Jan 22, 8:04 PM
This revision is now accepted and ready to land.Wed, Jan 22, 8:04 PM
mav accepted this revision.Thu, Jan 23, 4:26 PM

I guess instead of 1 could be expected some error codes, that just never happened.

jhb updated this revision to Diff 149825.Thu, Jan 23, 7:14 PM

Two more that I missed

This revision now requires review to proceed.Thu, Jan 23, 7:14 PM
Harbormaster completed remote builds in B61945: Diff 149825.Thu, Jan 23, 7:14 PM
asomers accepted this revision.Thu, Jan 23, 7:15 PM
This revision is now accepted and ready to land.Thu, Jan 23, 7:15 PM
Closed by commit rG78cd9f0c0941: ctld: Use bool in uclparse.c (authored by jhb). · Explain WhyFri, Jan 24, 2:55 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG78cd9f0c0941: ctld: Use bool in uclparse.c.

Revision Contents
Changeset List

PathSize
usr.sbin/
ctld/
254 lines

Diff 149825

View Options

usr.sbin/ctld/uclparse.c

Loading...